Re: switch-to-buffer incompatible behavior with Emacs 21

[Max Mikhanosha]

At Fri, 25 Aug 2006 03:44:17 -0400,
Richard Stallman wrote:
> 
> I think this fix is more correct.  Does it give good results?

Yes works fine with below patch also. I did not realized tho point of
the first "if" statement in the function was to fix a bug further
down, instead I thought it was a speed optimization hence my patch
that just bypassed it to fix buffer order. Should have read the
comments more carefully. 

Regards,
  Max

> 
> 
> *** buffer.c  22 Aug 2006 10:59:44 -0400      1.507
> --- buffer.c  24 Aug 2006 10:35:16 -0400      
> ***************
> *** 1684,1692 ****
>     char *err;
>   
>     if (EQ (buffer, Fwindow_buffer (selected_window)))
> !     /* Basically a NOP.  Avoid signalling an error if the selected window
> !        is dedicated, or a minibuffer, ...  */
> !     return Fset_buffer (buffer);
>   
>     err = no_switch_window (selected_window);
>     if (err) error (err);
> --- 1684,1699 ----
>     char *err;
>   
>     if (EQ (buffer, Fwindow_buffer (selected_window)))
> !     {
> !       /* Basically a NOP.  Avoid signalling an error in the case where
> !      the selected window is dedicated, or a minibuffer.  */
> ! 
> !       /* But do put this buffer at the front of the buffer list,
> !      unless that has been inhibited.  */
> !       if (NILP (norecord))
> !     record_buffer (buffer);
> !       return Fset_buffer (buffer);
> !     }
>   
>     err = no_switch_window (selected_window);
>     if (err) error (err);