[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-lisp/cl.el (pushnew): void-variable x
From: |
Reiner Steib |
Subject: |
Re: emacs-lisp/cl.el (pushnew): void-variable x |
Date: |
Mon, 11 Sep 2006 13:20:58 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) |
On Mon, Sep 11 2006, Kim F. Storm wrote:
> Reiner Steib <address@hidden> writes:
>> Is this change correct?
>>
>> --8<---------------cut here---------------start------------->8---
>> --- cl.el 11 Sep 2006 11:50:52 +0200 1.49
>> +++ cl.el 11 Sep 2006 12:32:09 +0200
>> @@ -160,7 +160,7 @@
>> (if (symbolp place)
>> (if (null keys)
>> `(let ((pushnew-internal ,place))
>> - (add-to-list 'pushnew-internal x nil 'eql)
>> + (add-to-list 'pushnew-internal ,x nil 'eql)
>> (setq ,place pushnew-internal))
>> (list 'setq place (list* 'adjoin x place keys)))
>> (list* 'callf2 'adjoin x place keys)))
>> --8<---------------cut here---------------end--------------->8---
>
> Yes it seems correct.
I have installed it.
> But what's the wisdom behind pushnew-internal [we already know that
> PLACE is a symbol]?
I don't know.
> If it is aimed at handling the situation where PLACE is not bound on
> entry, the let binding to pushnew-internal will also fail AFAICS.
>
> This looks equivalent to me: [...]
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
- emacs-lisp/cl.el (pushnew): void-variable x, Reiner Steib, 2006/09/11
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/11
- Re: emacs-lisp/cl.el (pushnew): void-variable x,
Reiner Steib <=
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Richard Stallman, 2006/09/11
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/11
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/11
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Stefan Monnier, 2006/09/11
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/12
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/12
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/12
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Stefan Monnier, 2006/09/12
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Richard Stallman, 2006/09/12
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Johan Bockgård, 2006/09/13