[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[emms-help] Re: Packaging as RPM and Makefile
From: |
Lucas Bonnet |
Subject: |
[emms-help] Re: Packaging as RPM and Makefile |
Date: |
Fri, 04 Jun 2010 10:46:53 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) |
Tim Landscheidt <address@hidden> writes:
> Hi,
Hello,
> As 3.0 is probably no longer maintained, the first patch
> may not be so interesting, but I noticed that HEAD's Make-
> file still bears the same characteristics, and before I have
> a try at packaging a development snapshot, I'd rather settle
> this first.
>
> Any thoughts?
I think you'd be better of packaging the HEAD (it should be very
stable), or maybe waiting until we manage to release a new version,
sometime in 2010 :)
> Thanks again for EMMS,
> Tim
>
> diff -urx '*~' emms-3.0.orig/emms-browser.el emms-3.0/emms-browser.el
[...]
Already patched in HEAD.
> diff -urx '*~' emms-3.0.orig/emms-stream-info.el emms-3.0/emms-stream-info.el
> --- emms-3.0.orig/emms-stream-info.el 2010-05-31 16:20:52.447823435 +0000
> +++ emms-3.0/emms-stream-info.el 2010-05-31 21:32:51.649825566 +0000
> @@ -440,22 +440,22 @@
[...]
Doesn't apply on HEAD, the file looks very different from the 3.0
release, I can't find the matching code.
> diff -urx '*~' emms-3.0.orig/emms-tag-editor.el emms-3.0/emms-tag-editor.el
> --- emms-3.0.orig/emms-tag-editor.el 2010-05-31 16:20:51.458823310 +0000
> +++ emms-3.0/emms-tag-editor.el 2010-05-31 21:32:10.432826625 +0000
[...]
Same as above. Wow, seems we modified EMMS significantly since 3.0
release :)
> diff -urx '*~' emms-3.0.orig/Makefile emms-3.0/Makefile
> --- emms-3.0.orig/Makefile 2010-05-31 16:20:53.158823378 +0000
> +++ emms-3.0/Makefile 2010-05-31 16:30:20.670825783 +0000
> @@ -8,13 +8,11 @@
> TARGET=$(patsubst %.el,%.elc,$(SOURCE))
> MAN1PAGES=emms-print-metadata.1
>
> -DESTDIR=
> -PREFIX=$(DESTDIR)/usr/local
> -INFODIR=$(PREFIX)/info
> -MAN1DIR=$(PREFIX)/share/man/man1
> -SITELISP=$(PREFIX)/share/emacs/site-lisp/emms
> +INFODIR=$(DESTDIR)/usr/share/info
> +MAN1DIR=$(DESTDIR)/usr/share/man/man1
> +SITELISP=$(DESTDIR)/usr/share/emacs/site-lisp/emms
Makes sense to me. Can someone else confirm that this won't break
everything? :)
> -INSTALLINFO = /usr/sbin/install-info --info-dir=$(INFODIR)
> +INSTALLINFO = /sbin/install-info --info-dir=$(INFODIR)
On my Debian, install-info is "/usr/bin/install-info" :(
Isn't there some sort of standardized way to guess all this stuff ? I
don't want the Makefile to be distro-specific. Using "$(which install-info)"
seems too obvious to me to be the proper way.
> .PHONY: all install deb-install clean
> .PRECIOUS: %.elc %.info %.html
> @@ -49,6 +47,7 @@
> install -m 644 $(ALLSOURCE) $(SITELISP)
> install -m 644 $(ALLCOMPILED) $(SITELISP)
> install -m 0644 emms.info $(INFODIR)/emms
> + test -d $(MAN1DIR) || mkdir -p $(MAN1DIR)
Shouldn't the -p option silence mkdir when the directory already exists?
In what case does this generate an error?
> for p in $(MAN1PAGES) ; do $(GZIP) -9c $$p > $(MAN1DIR)/$$p.gz ; done
> $(INSTALLINFO) emms.info
Thanks for your feedback, regards
--
Lucas
pgpimKkjufqtm.pgp
Description: PGP signature
- [emms-help] Re: Packaging as RPM and Makefile,
Lucas Bonnet <=
- [emms-help] Re: Packaging as RPM and Makefile, Tim Landscheidt, 2010/06/04
- [emms-help] Re: Packaging as RPM and Makefile, Tim Landscheidt, 2010/06/06
- [emms-help] Re: Packaging as RPM and Makefile, Tim Landscheidt, 2010/06/06
- [emms-help] Re: Packaging as RPM and Makefile, Lucas Bonnet, 2010/06/15
- [emms-help] Re: Packaging as RPM and Makefile, Tim Landscheidt, 2010/06/15
- [emms-help] Re: Packaging as RPM and Makefile, Lucas Bonnet, 2010/06/15
- [emms-help] Re: Packaging as RPM and Makefile, Tim Landscheidt, 2010/06/15
[emms-help] Re: Packaging as RPM and Makefile, Lucas Bonnet, 2010/06/07