Re: [Erc-discuss] DCC module broken?

[Tyler Spivey]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This almost works. I was able to send, receive and close almost successfully,
but a few things jumped out at me:
1. When I received a file of size 930448,
erc said at the end it was 1336208 bytes, but it was the correct
size on the filesystem and passed the md5sum test.

2. The only /dcc close I could get to work was /dcc close nick. /dcc close 
GET/get didn't do anything.

3. When I tried to receive a file with a .gz extension, I kept getting spammed 
with "compressing file.gz..." messages.
On Tue, Sep 30, 2008 at 11:36:55PM -0700, Michael Olson wrote:
> Tyler Spivey <address@hidden> writes:
> 
> > Hello. I wanted to use the erc dcc module, but found the following
> > problems with it (I'm sure there are more, but these just came up in
> > the first few commands):
> >
> > 1. erc-pack-int can return a string of any length. according to
> > http://www.irchelp.org/irchelp/rfc/ctcpspec.html, it is
> > supposed to be packed into a 4 byte unsigned integer in network byte
> > order, if I'm reading it correctly.
> >
> > 2. erc-dcc-do-CLOSE-command uses the line variable, which seems to
> > include the entire command, which its regexp isn't able to handle.
> >
> > 3. I had to let inhibit-read-only be t in erc-dcc-append-contents in
> > order for get to work.
> >
> > Am I doing things wrong, or is this module just broken and needs to be
> > fixed? I don't think I have the elisp knowledge to fix these issues in
> > a clean way, or I'd send a patch.
> 
> Thanks for the report -- I've checked in fixes for all three issues, but
> have not thoroughly tested the fix for #2 yet.  Please download the
> latest snapshot from http://mwolson.org/static/dist/erc-latest.tar.gz
> and let me know whether it works correctly now.
> 
> -- 
> |       Michael Olson  |  FSF Associate Member #652     |
> | http://mwolson.org/  |  Hobbies: Lisp, HCoop          |
> | Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
> `-------------------------------------------------------'
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkjjKyYACgkQTsjaYASMWKQQhwCghYqIyQH+dHUCDxMdz8WMVlcL
Dz0AoJRL/m0h5KGCJ3bNRbc634z9oFGR
=TzQ8
-----END PGP SIGNATURE-----