RFA: Field-Related Pooma Code Changes

[Jeffrey Oldham]

The majority of these changes consist of:
o Reorder constructor's initializers to reflect class declaration order.
o Add an initializer for the base class.
o Add `typename's.
o Change preprocessor line from `if' to `ifdef'.

Are these changes OK to commit?

2001-03-27  Jeffrey D. Oldham  <address@hidden>

        * Array/PrintArray.h (PrintArray::PrintArray): Reorder
        constructor's initializers to reflect class declaration order.
        * BConds/BCondList.h (BCondListData::BCondListData): Add an
        initializer for the base class.
        (BCondListData::~BCondListData): Change loop counter's type.
        (BCondListData): Add typedef for vector iteration.
        * BConds/LinExtrapFaceBC.h
        (LinearExtrapolateFaceBC::LinearExtrapolateFaceBC): Add a base
        class initializer.
        * BConds/NegReflectFaceBC.h
        (NegReflectFaceBC::NegReflectFaceBC): Likewise.
        * BConds/PeriodicFaceBC.h (PeriodicFaceBC::PeriodicFaceBC):
        Likewise.
        * BConds/PosReflectFaceBC.h (PosReflectFaceBC::PosReflectFaceBC):
        Likewise.
        * BConds/ZeroFaceBC.h (ZeroFaceBC::ZeroFaceBC):
        Likewise.
        * Domain/DomainRemoveOverlap.h (DomainRemoveOverlap): Add `typename's.
        * Domain/DomainTraits.Grid.h (DomainTraits::setDomain): Rewrite to
        ensure that comparisons occur between the same types.
        * Domain/DomainTraits.Interval.h (DomainTraits::setDomain): Likewise.
        * Domain/DomainTraits.Range.h (DomainTraits::setDomain): Likewise.
        * Domain/Grid.h (Grid::Grid): Add a base class initializer.
        * Engine/IndexFunctionEngine.h (Engine): Reorder constructor's
        initializers to reflect class declaration order.
        * Engine/RemoteEngine.h (GatherContextsData::GatherContextsData):
        Add a base class initializer.
        (Evaluator::evaluate): Add `typename's.
        * Evaluator/Evaluator.h (Evaluate::evaluate): Likewise.
        * Evaluator/ExpressionKernel.h
        (ExpressionKernel::ExpressionKernel): Change preprocessor line to
        `ifdef'.
        * Evaluator/MultiArgEvaluator.h (MultiArgEvaluator::evaluate): Add
        `typename's.
        * Evaluator/Reduction.h (Reduction::evaluate): Likewise.
        * Field/Field.cpp (assign): Likewise.
        * Field/Field.h (Field::array): Reorder template and `inline'.
        (Field::arrayAll): Likewise.
        * Field/PrintField.h (PrintField::PrintField): Reorder
        constructor's initializers to reflect class declaration order.
        * Layout/DynamicEvents.h (CreateEvent::CreateEvent): Likewise.
        (DestroyEvent::DestroyEvent): Likewise.
        (CopyEvent::CopyEvent): Likewise.
        (CopyPatchEvent::CopyPatchEvent): Likewise.
        * Layout/GlobalIDDataBase.h (Pack::Pack): Likewise.
        * Layout/GridLayout.cpp (GridLayoutData<Dim>::initialize): Add
        `typename's.
        * Layout/SparseTileLayout.cpp
        (SparseTileLayoutData<Dim>::~SparseTileLayoutData): Likewise.
        (SparseTileLayoutData<Dim>::calcMaps): Likewise.
        (SparseTileLayoutData<Dim>::calcAllocMaps): Likewise.
        (SparseTileLayoutData<Dim>::calcGCFillList): Likewise.
        (SparseTileLayoutData<Dim>::touches): Likewise.
        (SparseTileLayoutData<Dim>::touchesAlloc): Likewise.
        (SparseTileLayoutData<Dim>::print): Likewise.
        * Layout/UniformGridLayout.cpp
        (UniformGridLayoutData<Dim>::partition): Likewise.
        (UniformGridLayoutData<Dim>::initialize): Likewise.
        * Partition/BisectionMapper.h (BisectionMapper::map): Likewise.
        * Partition/UniformMapper.h (UniformMapper::~UniformMapper): New
        empty function.
        * Pooma/Pooma.h (poll): Change preprocessor line to `ifdef'.
        * Pooma/PoomaOperatorTags.h (FnMin::operator()): Likewise.
        (FnMax::operator()): Likewise.
        (FnMinAssign::operator()): Likewise.
        (FnMaxAssign::operator()): Likewise.
        * Threads/PoomaCSem.h: Likewise.
        * Threads/Scheduler.h: Likewise.
        * Utilities/Observer.h (SingleObserver::~SingleObserver): Make
        virtual.
        * Utilities/RefCountedBlockPtr.h
        (RefBlockController::RefBlockController): Reorder constructor's
        initializers to reflect class declaration order.
        (RefCountedBlockPtr): Change preprocessor line.
        (RefCountedBlockPtr::RefCountedBlockPtr): Reorder constructor's
        initializers to reflect class declaration order.
        * Utilities/algorithms.h (copy_special): Change preprocessor line
        to `ifdef'.
        (delete_backfill): Likewise.

Tested on       sequential Linux by compiling Pooma library using g++ mainline
Reviewed by     ????you????

****************

These errors were revealed by compiling this program:

#include <iostream>
#include <stdlib.h>
#include "Pooma/Fields.h"

int main(int argc, char *argv[])
{
  // Set up the Pooma library.
  Pooma::initialize(argc,argv);

  Pooma::finalize();
  return EXIT_SUCCESS;
}

Thanks,
Jeffrey D. Oldham
address@hidden

src-Mar27.patch
Description: Text document