freepooma-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [pooma-dev] RFA: Reorder Initializers (2 of 3)


From: James Crotinger
Subject: RE: [pooma-dev] RFA: Reorder Initializers (2 of 3)
Date: Wed, 28 Mar 2001 15:45:05 -0800

Why are these changes needed? I thought ordering didn't matter. Also, you added some explicit calls to default constructors - again, why?

(You may need to reply to address@hidden)

        Jim

---------------------------------------------------
James A. Crotinger
Software Research Scientist
Proximation, LLC

 -----Original Message-----
From:   Jeffrey Oldham [mailto:address@hidden]
Sent:   Wednesday, March 28, 2001 4:39 PM
To:     address@hidden
Subject:        [pooma-dev] RFA: Reorder Initializers (2 of 3)

 << File: Mar27-reorder.patch >> The large patch I sent out yesterday was too complicated.  Thus, I
have split it into five pieces:

1) Add typenames.                       
2) Reorder constructor initializers.    <-- this patch
3) Other changes.
4) Preprocessor changes. (withdrawn)
5) Changes to deprecated directories. (withdrawn)

I withdraw the large patch.  (I cut the large patch apart by hand so
small typos may be present.)

Scott Haney indicated he wants to review these changes.

2001-03-27  Jeffrey D. Oldham  <address@hidden>

        * Array/PrintArray.h (PrintArray::PrintArray): Reorder
        constructor's initializers to reflect class declaration order.
        * Domain/Grid.h (Grid::Grid): Add a base class initializer.
        * Engine/IndexFunctionEngine.h (Engine): Reorder constructor's
        initializers to reflect class declaration order.
        * Engine/RemoteEngine.h (GatherContextsData::GatherContextsData):
        Add a base class initializer.
        * Layout/DynamicEvents.h (CreateEvent::CreateEvent): Likewise.
        (DestroyEvent::DestroyEvent): Likewise.
        (CopyEvent::CopyEvent): Likewise.
        (CopyPatchEvent::CopyPatchEvent): Likewise.
        * Layout/GlobalIDDataBase.h (Pack::Pack): Likewise.
        * Utilities/RefCountedBlockPtr.h
        (RefBlockController::RefBlockController): Reorder constructor's
        initializers to reflect class declaration order.
        (RefCountedBlockPtr): Change preprocessor line.
        (RefCountedBlockPtr::RefCountedBlockPtr): Reorder constructor's
        initializers to reflect class declaration order.


Tested on       sequential Linux using gcc 3.1
Approved by     ???Scott Haney???

Thanks,
Jeffrey D. Oldham
address@hidden


reply via email to

[Prev in Thread] Current Thread [Next in Thread]