[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pooma-dev] RFA: Other Changes (3 of 3)
From: |
Scott Haney |
Subject: |
Re: [pooma-dev] RFA: Other Changes (3 of 3) |
Date: |
Wed, 28 Mar 2001 17:31:51 -0700 |
On Wednesday, March 28, 2001, at 04:41 PM, Jeffrey Oldham wrote:
The large patch I sent out yesterday was too complicated. Thus, I
have split it into five pieces:
1) Add typenames.
2) Reorder constructor initializers.
3) Other changes. <-- this patch
4) Preprocessor changes. (withdrawn)
5) Changes to deprecated directories. (withdrawn)
I withdraw the large patch. (I cut the large patch apart by hand so
small typos may be present.)
Allan Stokes suggested a different way to handle comparisons between
different types. Allan, can you provide code?
Allan Stokes declined to review the virtual destructors.
2001-03-27 Jeffrey D. Oldham <address@hidden>
* Domain/DomainTraits.Grid.h (DomainTraits::setDomain): Rewrite to
ensure that comparisons occur between the same types.
* Domain/DomainTraits.Interval.h (DomainTraits::setDomain): Likewise.
* Domain/DomainTraits.Range.h (DomainTraits::setDomain): Likewise.
* Partition/UniformMapper.h (UniformMapper::~UniformMapper): New
empty function.
* Utilities/Observer.h (SingleObserver::~SingleObserver): Make
virtual.
I don't understand why the casts should be required. Is this a compiler
bug?
While harmless (other than the virtual part), I don't understand why one
needs to add an empty virtual destructor to UniformMapper. I can't see
anyone inheriting from it. Why doesn't the compiler generate this?
The change to SingleObserver seems OK.
Scott