Changes to Head Version of Pooma for Tecolote

[John Hall]

Well:

I have the demo project passing all of the regression tests using the head version of Pooma through the PhysicsSupport layer. This was a considerable effort, but, things are looking pretty good.

While I was at it, I started with a virgin version of the Pooma Head version and found the following 3 problems which everyone must fix before we can use the Head version. If these are innocuous enough I would like to have them checked in, otherwise, our team will have to remember to change them every time we check out from scratch.

The first problem keeps the relations from being sorted by priority when they are added. This has not really been tested, since I haven't used relation groups yet, but, it appears to be wrong since the test will never be true otherwise.

The second problem is a simple typo. Once it was fixed our regression tests passed, the Pooma tests never tested this case.

The third set of changes is to make a common interface between "DomainLayout" and the other distributed layouts so that one code base compiles in both serial and distributed cases. The beginGlobal function is being called from the IO stuff Jim wrote. Everything seems to work with these changes, but, someone with a clearer overall picture should probably check it out. I just copied the "local" section and replaced "Local" with "Global".

I hope to have everything moved over to the head version by the end of next week. Then we have another effort to finish the physics that was not quite done by the end of the "Demo Project". I continue to believe that there is a need for this work and I intend to put it into reasonable shape so that I can get a group of users and re-establish support for what we were doing.

I hope that all of you are doing well and that you will remember us when "Numerics/Proximation" and CodeSourcery make you all rich and famous. Maybe those of us at the lab can become "your people" so that your other rich and famous friends will have someone to call when you say "Have your people call my people".

Anyhow, back to the grind. Don't forget, its Valentine's day, so you better have something by the time you go home.

John Hall

_________________________________________

Index: src/Field/Relations/RelationList.h
===================================================================
RCS file: /home/pooma/Repository/r2/src/Field/Relations/RelationList.h,v
retrieving revision 1.1
diff -r1.1 RelationList.h
131c131
<           if (data_m[i]->priority() <= data_m[i]->priority())
---
>           if (data_m[i]->priority() <= data_m[i - 1]->priority())

Index: src/Field/Relations/Relations.h
===================================================================
RCS file: /home/pooma/Repository/r2/src/Field/Relations/Relations.h,v
retrieving revision 1.2
diff -r1.2 Relations.h
186c186
<   Relation1(const Target &t, const R1 &r,
---

>   Relation1(const Target &t, const R1 &r1,

Index: src/Layout/DomainLayout.h
===================================================================
RCS file: /home/pooma/Repository/r2/src/Layout/DomainLayout.h,v
retrieving revision 1.25
diff -r1.25 DomainLayout.h
341a342,364

>   // Return begin and end iterators for the list of all global subdomains (there are no others of course)

>
>   inline iterator beginGlobal()
>     {
>       return begin();
>     }
>   inline iterator endGlobal()
>     {
>       return end();
>     }
>   inline const_iterator beginGlobal() const
>     {
>       return begin();
>     }
>   inline const_iterator endGlobal() const
>     {
>       return end();
>     }
>   inline long sizeGlobal() const
>     {
>       return size();
>     }
>

--