Re: positive descender with type1 fonts

[David Turner]

Hi Karsten,

"Fleischer, Karsten (K.)" a écrit :
> 
> Hi,
> 
> when using Type1 fonts with FreeType2-current (as of Sept. 5th) the
> descender is set to a positive value.
> Changing the following lines in type1z/z1objs.c, function Z1_Init_Face
> 
>       root->descender    = -(FT_Short)face->type1.font_bbox.yMin;
>       root->height       = ( ( root->ascender + root->descender ) * 12 ) /
> 10;
> 
> to
> 
>       root->descender    =  (FT_Short)face->type1.font_bbox.yMin;
>       root->height       = ( ( root->ascender - root->descender ) * 12 ) /
> 10;
> 
> fixes it, right?
> 

Yes, it's an obvious bug. FreeType uses the TrueType convention
of returning negative descenders (well, for typical fonts :-)

Or, we could change the convention to only return positive values.
I would like Werner's opinion before committing your patch..

Thanks a lot,

- David

> Karsten