[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Devel] truetype loader crashes in current CVS version
From: |
Just van Rossum |
Subject: |
Re: [Devel] truetype loader crashes in current CVS version |
Date: |
Thu, 25 Jul 2002 08:52:33 +0200 |
Werner LEMBERG wrote:
> > > Sven, I made an entry in the CVS log for the changed file, and
> > > even credited you ;-) I didn't realise there was some other log as
> > > well. Seems like duplication... and it's been a busy, busy
> > > day. But I shall look for the change log and see if I can put an
> > > entry there as well.
> >
> > Well, Graham, the idea is that for every change you commit, you are
> > supposed to write a little explanation for CVS, right? So what we
> > are supposed to do is to format this change is a more or less
> > uniform way, and as soon as you commit something through CVS, you
> > add the same comment to ./ChangeLog, and you update it to CVS. This
> > makes the job of the other people that monitor the development (like
> > David and Werner, but perhaps others) much easier. It also eases
> > *a*lot* when there is a regression problem with an older version.
>
> Usually, I walk through all code, improving/fixing the ChangeLog
> entries (in most cases they are not detailed enough or don't follow
> the standard). Maybe I'm paranoid, but, as Antoined said, the
> benefits are *extremely* helpful to find troubles with older code.
Erm, why maintain ChangeLog manually? There are scripts that _build_
ChangeLog-like files directly from CVS. Eg. in the Python distribution
there's a script called logmerge.py that does exactly that.
> In
> Emacs, Stallman is going even farther: He insists that a single
> ChangeLog entry corresponds to a single CVS change and vice versa so
> that you can really check up the exact diffs.
One commit message should apply to one set of changes, and I think that can be
across files as long as the message indeed applies to the whole set. What I
think is bad (and what I see quite a bit in the FreeType CVS messages) is one
message describing a whole bunch of unrelated changes in several files...
Another thing that _really_ helps code review is adding a diff to the CVS log
email. I use a Python script called syncmail for this, it works very well:
http://sourceforge.net/projects/cvs-syncmail
(The Python project itself uses it, too.)
Just
- [Devel] truetype loader crashes in current CVS version, Sven Neumann, 2002/07/24
- RE: [Devel] truetype loader crashes in current CVS version, Graham Asher, 2002/07/24
- RE: [Devel] truetype loader crashes in current CVS version - fix, Graham Asher, 2002/07/24
- RE: [Devel] truetype loader crashes in current CVS version, Graham Asher, 2002/07/24
- Re: [Devel] truetype loader crashes in current CVS version, Sven Neumann, 2002/07/24
- RE: [Devel] truetype loader crashes in current CVS version, Graham Asher, 2002/07/24
- Re: [Devel] truetype loader crashes in current CVS version, Sven Neumann, 2002/07/24
- RE: [Devel] truetype loader crashes in current CVS version, Antoine Leca, 2002/07/24
- Re: [Devel] truetype loader crashes in current CVS version, Werner LEMBERG, 2002/07/24
- Re: [Devel] truetype loader crashes in current CVS version,
Just van Rossum <=
- Re: [Devel] truetype loader crashes in current CVS version, Owen Taylor, 2002/07/25
- Re: [Devel] truetype loader crashes in current CVS version, Werner LEMBERG, 2002/07/25
- Re: [Devel] truetype loader crashes in current CVS version, Just van Rossum, 2002/07/25
- Re: [Devel] truetype loader crashes in current CVS version, Werner LEMBERG, 2002/07/25
- [Devel] Comments are not skipped properly in Type 1 fonts, Graham Asher, 2002/07/26
- RE: [Devel] truetype loader crashes in current CVS version, Graham Asher, 2002/07/25