[Devel] negative descender

[Jens Rosenboom]

Dear All,

the second bug(?) regarding a negative face->descender is fixed by the
attached patch.

Best Regards,

Jens Rosenboom
> --- Begin Message ---
>
>
>
> Subject: 
>
> negative descender
>
>
>
>
> Date: 
>
> Thu, 15 Aug 2002 13:19:41 +0200
>
>
>
>
> Dear All,
>
> in the html-reference of freetype 2.1.2
> (freetype-2.1.2/docs/reference/ft2-base_interface.html#FT_FaceRec) you
> state, that descender is always positive. But in pfrobjs.c, line 138 its
> value is directly taken from the negative "bbox.yMin". Also in ".ttf"
> fonts this seems to true (but I'm not sure). Is this an API change or a
> mistake (maybe mine)?
>
> Best Regards,
>
> Jens Rosenboom
>
> P.S: You made a good font library :-)
>
> --- End Message ---
diff -u -r1.1 -r1.2
--- freetype/sfobjs.c   2002/08/14 12:23:27     1.1
+++ freetype/sfobjs.c   2002/08/15 15:18:53     1.2
@@ -727,9 +727,9 @@
         /*                                                                */
 
         root->ascender  = face->horizontal.Ascender;
-        root->descender = face->horizontal.Descender;
+        root->descender = -face->horizontal.Descender;
 
-        root->height    = (FT_Short)( root->ascender - root->descender +
+        root->height    = (FT_Short)( root->ascender + root->descender +
                                       face->horizontal.Line_Gap );
 
         /* if the line_gap is 0, we add an extra 15% to the text height --  */