Re: [Devel] PATCH: allow all faces to be used from Mac fonts

[Dan Williams]

Hi,

Any comments on the preliminary patch?  We need to work swiftly if any 
of these changes are going to make it into the 4.3 release of XFree86 
for Darwin.

Thanks,
Dan

On Thursday, February 13, 2003, at 12:33  PM, Dan Williams wrote:
> Hi,
>
> I have here a preliminary patch that allows more than the first face 
> to be used from Freetype for mac fonts, both suitcases and dfonts.  
> This patch is _NOT_ submission quality, I'm simply posting it to get a 
> review if this is the right thing to do.
>
> Caveats with the patch:
> 1)  Whacked up to support gcc building with -DTARGET_API_MAC_CARBON, 
> not using CodeWarrior (ignore #include changes)
> 2)  Hack to make both suitcases and dfonts use 
> FT_New_Face_From_dfont().  This function would get renamed.
> 3)  Doesn't work with some fonts like LastResort.dfont, 
> Keyboard.dfont, Taipei.dfont, Beijing.dfont, perhaps because they do 
> not have the correct TrueType version identifier in their 'sfnt' 
> headers.  Crashes on FT_FREE(stream) in open_face_from_buffer().
> 4)  Whitespace changes
>
> With these in mind, please review the patch and see if the method 
> seems acceptable.
>
> Thanks,
> Dan

ftmac.c.MANYFACES.patch
Description: Binary data