RE: [ft-devel] FreeType 2.3.5 - incorrect bitmap_left / horiBearingX values with Symbol TT font

[Bevan, David]

> -----Original Message-----

> From: Werner LEMBERG [mailto:address@hidden

> Sent: 25 February 2008 10:58

> To: Bevan, David

> Cc: address@hidden; Brazier, Stephen; Ghoshal, Ronen; Nagpal,

> Shipra

> Subject: Re: [ft-devel] FreeType 2.3.5 - incorrect bitmap_left /

> horiBearingX values with Symbol TT font

>

>

> > Is there any harm in making the following change in TT_Load_Glyph()

> >

> >   Replace

> >

> >     if ( ( face->header.Flags & 2 ) == 0 && loader.pp1.x )

> >       FT_Outline_Translate( &glyph->outline, -loader.pp1.x, 0 );

> >

> >   with

> >

> >     if ( loader.pp1.x )

> >       FT_Outline_Translate( &glyph->outline, -loader.pp1.x, 0 );

> >

> > in order to accommodate bad fonts like this?

> >

> > Or does this have some unwanted side-effect?

>

> There are buggy fonts which exhibit exactly the opposite behaviour,

> this is, they would display incorrectly if we reverted this patch.  (I

> forgot the details, but I've added this code due to a bug report --

> maybe you can find it somewhere in the list archive.)

 

OK. Thanks. I found the change:

 

ttgload.c

Revision 1.148

Mon Aug 22 07:11:31 2005 UTC (2 years, 6 months ago) by wl

Changes since 1.147: +3 -2 lines

 

* src/truetype/ttgload.c (TT_Load_Glyph): Only translate outline

to (0,0) if bit 1 of the `head' table isn't set.  This improves

rendering of buggy fonts.

 

Now I have to choose which buggy fonts to support and which not to!

 

David %^>