[Gcjwebplugin-devel] a few notes

[Tom Tromey]

I tried building gcjwebplugin today.

First, it doesn't install properly for me.  At least with libtool
1.5.2, no file named '.libs/libgcjwebplugin.so' is made, so the custom
'install' step fails.  A change (appended) to make this not use a
custom install rule still does not do the right thing, I think,
because the installed library doesn't have a '.so' suffix.

Second, I see this:

    Makefile:616: warning: overriding commands for target `gcjappletviewer'
    Makefile:548: warning: ignoring old commands for target `gcjappletviewer'

Automake doesn't really understand the conditional AC_CONFIG_FILES
call in configure.ac, so it makes the resulting Makefile rule
unconditional.  I think one fix for this would be to unconditionally
call AC_CONFIG_FILES, rename the file it generates, and then in the
Makefile.am have a conditional rule like:

    gcjappletviewer: cfappletviewer
        cp cfappletviewer gcjappletviewer


Third, the code in StandaloneAppletViewer.java that adds '.class' to
the argument is it does not see a suffix is buggy.  In particular, if
you try my test case you will see weird results; commenting out this
bit of code makes it work:

  ./gcjappletviewer  http://www.chessgames.com/perl/chessgame?gid=1069669

This gets far enough to display the chess board, then fails.  First
there is an exception, the applet makes an incorrect substring() call
-- I'm not sure if this causes the other problems or not.  This works
fine with the JDK, so there is definitely a bug somewhere.  It could
be that we report exceptions while the JDK does not, and that the bug
is unrelated to the bad substring() call.

I'm impressed that it gets as far as it does.  That is pretty cool.

Tom

Index: ChangeLog
from  Tom Tromey  <address@hidden>

        * Makefile.am (plugindir): New variable.
        (plugin_LTLIBRARIES): Renamed from lib_LTLIBRARIES.
        (install-libLTLIBRARIES): Removed.
        (uninstall-libLTLIBRARIES): Likewise.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/gcjwebplugin/gcjwebplugin/Makefile.am,v
retrieving revision 1.15
diff -u -r1.15 Makefile.am
--- Makefile.am 20 Feb 2005 08:29:43 -0000 1.15
+++ Makefile.am 14 May 2005 18:48:23 -0000
@@ -123,7 +123,9 @@
 
 endif # ! BUILD_NATIVE_VIEWER
 
-lib_LTLIBRARIES = libgcjwebplugin.la
+plugindir = $(PLUGIN_DIR)
+
+plugin_LTLIBRARIES = libgcjwebplugin.la
 
 libgcjwebplugin_la_SOURCES = src/gcjwebplugin.cc
 
@@ -134,13 +136,6 @@
        $(GLIB_LIBS) \
        -lstdc++
 
-install-libLTLIBRARIES: $(lib_LTLIBRARIES)
-       $(INSTALL) -d -m0755 $(DESTDIR)@PLUGIN_DIR@
-       $(INSTALL) .libs/libgcjwebplugin.so $(DESTDIR)@PLUGIN_DIR@
-
-uninstall-libLTLIBRARIES:
-       rm -f $(DESTDIR)@PLUGIN_DIR@/libgcjwebplugin.so
-
 check_PROGRAMS = test
 
 test_SOURCES = src/test.cc