Re: [gcmd-dev] Clicking the SMB button causes SIGSEGV in libgnomevfs-2.so.0

[Manuel Bua]

I was able to debug: my suspect was the GnomeCmdSmbPath's members "path,
resource, resource_path, workgroup and display_path" weren't initialized and
were being used without checking for them being null.
I added a couple of checks as well as a comment/question since i'm not
practiced with gnomecmd source code at all.
It works fine now, patch is attached, feel free to modify/gnomecmd-ize it :)


On Tue, Jun 21, 2011 at 8:48 PM, Manuel Bua <address@hidden> wrote:

> On 06/21/2011 07:13 PM, Piotr Eljasiak wrote:
> > Hi,
> >
> > I guess I've found the cause for the SMB crashes - I've just committed
> > the fix into to master branch (commit
> > 7c8a8871524195208b8da8e5e4d7426216cdb9ce).
> >
> Thank you for getting back to me: unfortunately it still crashes,
> however the location is different as you can see:
>
>
> [Thread 0x7fffe0978700 (LWP 12699) exited]
> [MM] Opening connection
> [LL] Connecting to smb:///
> [New Thread 0x7fffe0054700 (LWP 12701)]
> [MM] GnomeCmdCon::OPEN_OK detected
>
> Program received signal SIGSEGV, Segmentation fault.
> __strlen_sse42 () at ../sysdeps/x86_64/multiarch/strlen.S:54
> 54    ../sysdeps/x86_64/multiarch/strlen.S: No such file or directory.
>    in ../sysdeps/x86_64/multiarch/strlen.S
> (gdb) bt
> #0  __strlen_sse42 () at ../sysdeps/x86_64/multiarch/strlen.S:54
> #1  0x00007ffff317bd52 in g_strdup () from /lib/libglib-2.0.so.0
> #2  0x00000000004347d0 in GnomeCmdSmbPath (this=0xc087c0) at
> gnome-cmd-smb-path.h:57
> #3  GnomeCmdSmbPath::do_clone (this=0xc087c0) at gnome-cmd-smb-path.h:38
> #4  0x0000000000447a86 in clone (con=0x7ec100) at gnome-cmd-path.h:31
> #5  gnome_cmd_dir_new_with_con (con=0x7ec100) at gnome-cmd-dir.cc:290
> #6  0x000000000043562d in check_con_open_progress (con=0x7ec100) at
> gnome-cmd-con.cc:255
> #7  0x00007ffff315bb1b in ?? () from /lib/libglib-2.0.so.0
> #8  0x00007ffff315b342 in g_main_context_dispatch () from
> /lib/libglib-2.0.so.0
> #9  0x00007ffff315f2a8 in ?? () from /lib/libglib-2.0.so.0
> #10 0x00007ffff315f7b5 in g_main_loop_run () from /lib/libglib-2.0.so.0
> #11 0x00007ffff57a03e7 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
> #12 0x000000000048b5e5 in main (argc=<value optimized out>, argv=<value
> optimized out>) at main.cc:181
>
> If i can find the time i'll try debug it so that i could give some other
> meaningful information..
>



-- 
Manuel

0001-Fix-SEGFAULTS-generated-by-trying-to-browse-Samba-sh.patch
Description: Text Data