Re: [gcmd-dev] Clicking the SMB button causes SIGSEGV in libgnomevfs-2.so.0

[Piotr Eljasiak]

Dnia 2011-06-22, śro o godzinie 17:41 +0200, Manuel Bua pisze:
> I was able to debug: my suspect was the GnomeCmdSmbPath's members
> "path,
> resource, resource_path, workgroup and display_path" weren't
> initialized and
> were being used without checking for them being null.
> I added a couple of checks as well as a comment/question since i'm not
> practiced with gnomecmd source code at all.
> It works fine now, patch is attached, feel free to modify/gnomecmd-ize
> it :)

Applied, thanks. I've dropped the part for:

 inline GnomeCmdSmbPath::GnomeCmdSmbPath(const GnomeCmdSmbPath &thePath)

as g_strdup() can handle NULL nicely and doesn't need extra checks
against it...


Please do test,

Piotr