[Gnash-commit] gnash ChangeLog server/as_function.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/03/29 22:04:00

Modified files:
        .              : ChangeLog 
        server         : as_function.cpp 

Log message:
        (constructInstance): don't assume a class will always have a prototype
        defined. Fixes leftover crashes in swfdec testsuite.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6084&r2=1.6085
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_function.cpp?cvsroot=gnash&r1=1.51&r2=1.52

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6084
retrieving revision 1.6085
diff -u -b -r1.6084 -r1.6085
--- ChangeLog   29 Mar 2008 22:01:48 -0000      1.6084
+++ ChangeLog   29 Mar 2008 22:04:00 -0000      1.6085
@@ -1,5 +1,8 @@
 2008-03-29 Sandro Santilli <address@hidden>
 
+       * server/as_function.cpp (constructInstance): don't assume a class
+         will always have a prototype defined. Fixes leftover crashes
+         in swfdec testsuite.
        * testsuite/libnet.all/test_http.cpp: its' amf::AMF::FILETYPE_SWF 
          today (when do you want to go tomorrow?)
 

Index: server/as_function.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_function.cpp,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -b -r1.51 -r1.52
--- server/as_function.cpp      12 Mar 2008 21:20:48 -0000      1.51
+++ server/as_function.cpp      29 Mar 2008 22:04:00 -0000      1.52
@@ -407,12 +407,16 @@
        {
                // Set up the prototype.
                as_value        proto;
-               // We can safaly call as_object::get_member here as member name 
is 
+
+               // We can safely call as_object::get_member here as member name 
is 
                // a literal string in lowercase. (we should likely avoid 
calling
                // get_member as a whole actually, and use a getProto() or 
similar
                // method directly instead) TODO
-               bool func_has_prototype = get_member(NSV::PROP_PROTOTYPE, 
&proto);
-               assert(func_has_prototype);
+               /*bool func_has_prototype=*/ get_member(NSV::PROP_PROTOTYPE, 
&proto);
+
+               // user could have dropped the prototype..
+               // see construct-properties-#.swf from swfdec testsuite
+               //assert(func_has_prototype);
 
                IF_VERBOSE_ACTION (
                log_action(_("constructor prototype is %s"), 
proto.to_debug_string().c_str());