[Gnash-commit] gnash ChangeLog server/as_function.cpp server/a...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/03/30 13:28:59

Modified files:
        .              : ChangeLog 
        server         : as_function.cpp as_function.h 
        testsuite/swfdec: PASSING 

Log message:
        don't provide a prototype member to builtin function if not requested 
so.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6089&r2=1.6090
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_function.cpp?cvsroot=gnash&r1=1.53&r2=1.54
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_function.h?cvsroot=gnash&r1=1.21&r2=1.22
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/swfdec/PASSING?cvsroot=gnash&r1=1.108&r2=1.109

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6089
retrieving revision 1.6090
diff -u -b -r1.6089 -r1.6090
--- ChangeLog   30 Mar 2008 12:55:46 -0000      1.6089
+++ ChangeLog   30 Mar 2008 13:28:57 -0000      1.6090
@@ -1,5 +1,11 @@
 2008-03-30 Sandro Santilli <address@hidden>
 
+       * server/as_function.{cpp,h}: don't provide a prototype
+         member to builtin function if not requested so.
+       * testsuite/swfdec/PASSING: function-properties-{6,7,8} succeed.
+
+2008-03-30 Sandro Santilli <address@hidden>
+
        * server/as_function.cpp, server/builtin_function.h
          server/asobj/ClassHierarchy.cpp: have function's
          constructor property set to Function.

Index: server/as_function.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_function.cpp,v
retrieving revision 1.53
retrieving revision 1.54
diff -u -b -r1.53 -r1.54
--- server/as_function.cpp      30 Mar 2008 12:55:47 -0000      1.53
+++ server/as_function.cpp      30 Mar 2008 13:28:58 -0000      1.54
@@ -111,10 +111,6 @@
        {
                init_member(NSV::PROP_uuPROTOuu, 
as_value(getFunctionPrototype()));
        }
-
-       as_object* iface = new as_object(getObjectInterface());
-       iface->init_member("constructor", this); 
-       init_member("prototype", as_value(iface));
 }
 
 

Index: server/as_function.h
===================================================================
RCS file: /sources/gnash/gnash/server/as_function.h,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -b -r1.21 -r1.22
--- server/as_function.h        6 Mar 2008 05:22:52 -0000       1.21
+++ server/as_function.h        30 Mar 2008 13:28:58 -0000      1.22
@@ -151,10 +151,9 @@
        }
 #endif // GNASH_USE_GC
 
-       /// Construct a function with a default interface
+       /// Construct a function with no interface
        //
-       /// The default interface will have derive from Object and 
-       /// have 'this' set as it's 'constructor' member. 
+       /// For SWF>5 the function object will have derive from Function.
        ///
        as_function();
 

Index: testsuite/swfdec/PASSING
===================================================================
RCS file: /sources/gnash/gnash/testsuite/swfdec/PASSING,v
retrieving revision 1.108
retrieving revision 1.109
diff -u -b -r1.108 -r1.109
--- testsuite/swfdec/PASSING    28 Mar 2008 17:16:12 -0000      1.108
+++ testsuite/swfdec/PASSING    30 Mar 2008 13:28:58 -0000      1.109
@@ -209,11 +209,11 @@
 extends-constructors-8.swf:b812f8e472f897a73914d10101841b87
 extends-simple.swf:5e3daf1e64d50b0c9ef06f7ad99f2bda
 extends-super.swf:d6aa7d61f452c5ee3ff64876ad70263a
+externalinterface-escape-6.swf:a1e0bb4872f756050aa52aada9837599
+externalinterface-escape-7.swf:b46b59523afba95c3bf6ea03ba8052ce
 external-interface-properties-5.swf:6c1da3512318203a18e0d5c3454f4a7e
 external-interface-properties-6.swf:1042fe711f2229195781f9ea1405fe66
 external-interface-properties-7.swf:1209e63fc5cadd41f854b3686ec9984f
-externalinterface-escape-6.swf:a1e0bb4872f756050aa52aada9837599
-externalinterface-escape-7.swf:b46b59523afba95c3bf6ea03ba8052ce
 file-reference-list-properties-5.swf:47e812391ae3b295a7f85dc5ab988179
 file-reference-list-properties-5.swf:4d13076bcc6ab1cd02fea9f62d4013cf
 file-reference-properties-5.swf:238ae6d8bf7d0ee8a241f20cf1247e6e
@@ -245,6 +245,9 @@
 function-apply-crash-6.swf:d37c7e90d823363dcc4052167fcbb754
 function-apply-crash-7.swf:28334f00875b4d137083a98c13fbab87
 function-apply-crash-8.swf:d61b9cf7bb66862cb82e6b6f67ffe9d6
+function-properties-6.swf:860c71e8d7dcc693ba95d0329c4ef084
+function-properties-7.swf:7100b7c2c31e05f85102669e7f054444
+function-properties-8.swf:fa1962a1efe9bfc01b652db45c8f4354
 function-prototype-chain.swf:cceb066a3cd0ed4060b36bd96e809236
 function-scope-5.swf:0176b1b93953a12b273106fe34add255
 function-scope-5.swf:562a01f98bc39cf16f4612c3194ad29e