[Gnash-commit] gnash ChangeLog server/as_function.cpp testsuit...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/03/30 14:46:56

Modified files:
        .              : ChangeLog 
        server         : as_function.cpp 
        testsuite/swfdec: PASSING 

Log message:
        Don't protect '__constructor__' and 'constructor' members of new 
instances
        from deletion. Fixes some swfdec testcases.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6090&r2=1.6091
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_function.cpp?cvsroot=gnash&r1=1.54&r2=1.55
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/swfdec/PASSING?cvsroot=gnash&r1=1.109&r2=1.110

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6090
retrieving revision 1.6091
diff -u -b -r1.6090 -r1.6091
--- ChangeLog   30 Mar 2008 13:28:57 -0000      1.6090
+++ ChangeLog   30 Mar 2008 14:46:55 -0000      1.6091
@@ -1,5 +1,12 @@
 2008-03-30 Sandro Santilli <address@hidden>
 
+       * server/as_function.cpp: __constructor__ and constructor
+         members given to new instances are not protected from
+         deletion.
+       * testsuite/swfdec/PASSING: video-properties-{6,7,8}.swf pass.
+
+2008-03-30 Sandro Santilli <address@hidden>
+
        * server/as_function.{cpp,h}: don't provide a prototype
          member to builtin function if not requested so.
        * testsuite/swfdec/PASSING: function-properties-{6,7,8} succeed.

Index: server/as_function.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_function.cpp,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -b -r1.54 -r1.55
--- server/as_function.cpp      30 Mar 2008 13:28:58 -0000      1.54
+++ server/as_function.cpp      30 Mar 2008 14:46:56 -0000      1.55
@@ -396,11 +396,11 @@
                // won't set __constructor__ to some other value...
                if ( swfversion > 5 )
                {
-                       newobj->init_member("__constructor__", as_value(this));
+                       newobj->init_member("__constructor__", as_value(this), 
as_prop_flags::dontEnum); // can delete
 
                        if ( swfversion == 6 )
                        {
-                               newobj->init_member("constructor", 
as_value(this));
+                               newobj->init_member("constructor", 
as_value(this), as_prop_flags::dontEnum); // can delete
                        }
                }
 
@@ -431,11 +431,11 @@
                // (to be checked)
                if ( swfversion > 5 )
                {
-                       newobj->init_member("__constructor__", as_value(this));
+                       newobj->init_member("__constructor__", as_value(this), 
as_prop_flags::dontEnum); // can delete
 
                        if ( swfversion == 6 )
                        {
-                               newobj->init_member("constructor", 
as_value(this));
+                               newobj->init_member("constructor", 
as_value(this), as_prop_flags::dontEnum); // can delete
                        }
                }
 

Index: testsuite/swfdec/PASSING
===================================================================
RCS file: /sources/gnash/gnash/testsuite/swfdec/PASSING,v
retrieving revision 1.109
retrieving revision 1.110
diff -u -b -r1.109 -r1.110
--- testsuite/swfdec/PASSING    30 Mar 2008 13:28:58 -0000      1.109
+++ testsuite/swfdec/PASSING    30 Mar 2008 14:46:56 -0000      1.110
@@ -779,6 +779,9 @@
 undefinedtrace-v7.swf:
 undefinedtrace-v8.swf:
 unloadmovie-simple-5.swf:3b897f539cb7eb764692def6fcc62853
+video-properties-6.swf:95109f25a5cac0fe2d18628dcea22633
+video-properties-7.swf:64f07e267ae93cdefec5c51c3fc9981d
+video-properties-8.swf:389ff730a73ec2c24f107abe9de0fa61
 with-delete-5.swf:e4db8598315a7f70785e7e96af7f3c3f
 with-delete-6.swf:49de7093280168a4013377eaf7753fa0
 with-delete-7.swf:f7668d30827a77f415ec325f052125c6