gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] /srv/bzr/gnash/trunk r10720: setQuality() has to be used


From: Benjamin Wolsey
Subject: [Gnash-commit] /srv/bzr/gnash/trunk r10720: setQuality() has to be used in movie_root initialization to inform the renderer
Date: Thu, 19 Mar 2009 08:17:15 +0100
User-agent: Bazaar (1.5)

------------------------------------------------------------
revno: 10720
committer: Benjamin Wolsey <address@hidden>
branch nick: trunk
timestamp: Thu 2009-03-19 08:17:15 +0100
message:
  setQuality() has to be used in movie_root initialization to inform the 
renderer
  of the initial quality. At this point _quality is either uninitialized or
  set to something sensible; in either case checking the requested quality
  against the set _quality is useless.
  
  Rather than duplicating the entire function without a check, setQuality()
  is now never a no-op. An alternative would be an extra flag that skips the
  check when necessary.
modified:
  libcore/movie_root.cpp
=== modified file 'libcore/movie_root.cpp'
--- a/libcore/movie_root.cpp    2009-03-18 16:51:47 +0000
+++ b/libcore/movie_root.cpp    2009-03-19 07:17:15 +0000
@@ -1430,8 +1430,6 @@
 {
     gnash::RcInitFile& rcfile = gnash::RcInitFile::getDefaultInstance();
 
-    if ( _quality == q ) return; // no op
-
     /// Overridden quality if not negative.
     if (rcfile.qualityLevel() >= 0) {
         int ql = rcfile.qualityLevel();


reply via email to

[Prev in Thread] Current Thread [Next in Thread]