Re: [Gnash-commit] /srv/bzr/gnash/trunk r10720: setQuality() has to be used in movie_root initialization to inform the renderer

[strk]

On Thu, Mar 19, 2009 at 08:17:15AM +0100, Benjamin Wolsey wrote:
> ------------------------------------------------------------
> revno: 10720
> committer: Benjamin Wolsey <address@hidden>
> branch nick: trunk
> timestamp: Thu 2009-03-19 08:17:15 +0100
> message:
>   setQuality() has to be used in movie_root initialization to inform the 
> renderer
>   of the initial quality. At this point _quality is either uninitialized or
>   set to something sensible; in either case checking the requested quality
>   against the set _quality is useless.
>   
>   Rather than duplicating the entire function without a check, setQuality()
>   is now never a no-op. An alternative would be an extra flag that skips the
>   check when necessary.

The problem is:
        - You have a huge (full-screen) bitmap
        - Trying to reduce client load you set _quality
          in frame0
        - Gnash will keep redrawing the bitmap, even
          if not required (as _quality doesn't change)

The above is the reason for the no-op to exist

--strk;