[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-173-g1373211

[Benjamin Wolsey]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  13732116819cb9a9d93f545d9f96e48536e6731e (commit)
      from  0593fc9c8e40b831ad20900493914e2aaacb5b00 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=13732116819cb9a9d93f545d9f96e48536e6731e


commit 13732116819cb9a9d93f545d9f96e48536e6731e
Author: Benjamin Wolsey <address@hidden>
Date:   Thu Mar 3 12:22:53 2011 +0100

    Cleanup comments and add a virtual dtor for safety
    (although one is implicitly generated as long as it
    derives from SWF::DefinitionTag).

diff --git a/libcore/parser/movie_definition.h 
b/libcore/parser/movie_definition.h
index c829c6e..9cbab3b 100644
--- a/libcore/parser/movie_definition.h
+++ b/libcore/parser/movie_definition.h
@@ -93,13 +93,6 @@ namespace gnash
 /// and SWFMovieDefinition (a top-level movie) to derive from
 /// a common class to allow tag_loaders to take a pointer
 /// to the base class to act on (consider PLACEOBJECT tags...).
-///
-/// This design is uncomfortable when it comes to programmatically
-/// created DisplayObjects, in that they do NOT have any *fixed* definition.
-/// A possible workaround to this would be not *requiring* DisplayObject
-/// instances to have an associated DefinitionTag. I'll work on this
-/// --strk 2006-12-05.
-///
 class movie_definition : public SWF::DefinitionTag
 {
 public:
@@ -227,10 +220,6 @@ public:
                return false;
        }
 
-       //
-       // For use during creation.
-       //
-
        /// Returns 1 based index. Ex: if 1 then 1st frame as been fully loaded
        virtual size_t  get_loading_frame() const = 0;
 
@@ -469,10 +458,13 @@ public:
 
 #endif
 protected:
+
     movie_definition(boost::uint16_t id = 0)
         :
         DefinitionTag(id)
     {}
+
+    virtual ~movie_definition() {}
 };
 
 } // namespace gnash

-----------------------------------------------------------------------

Summary of changes:
 libcore/parser/movie_definition.h |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
Gnash