[Gnash-commit] [bug #38084] Superclass prototype method call failure

[bl0ckeduser]

Follow-up Comment #9, bug #38084 (project gnash):

Hello,

I have written a patch that fixes the issue. I have run the testcases via
"make check" both on a clean master copy of the gnash git repo and with my
patch applied. Running a diff -u of the obtained results (summarized via
the analyse-results.sh script) shows that with my patch, the total number
of passes was 47428, and without, 47427. (I'm not sure why this is). My
patch did not introduce any failures. However, both with and without my
patch applied I obtained the following testing errors:

Unexpected failures follow:
 --=[ testsuite/actionscript.all ]=-- 
FAIL: astests-v6-Runner: no onSoundComplete arrived after 3 seconds
FAIL: astests-v6-Runner: Tests run 107 (expected 111) [ [./Sound.as:31]]
FAIL: astests-v7-Runner: no onSoundComplete arrived after 3 seconds
FAIL: astests-v7-Runner: Tests run 107 (expected 111) [ [./Sound.as:31]]
FAIL: astests-v8-Runner: no onSoundComplete arrived after 3 seconds
FAIL: astests-v8-Runner: Tests run 107 (expected 111) [ [./Sound.as:31]]

So my patch has not introduced any regressions.

I hope I have not made any coding mistakes and that the code quality is
good enough for your standards.

I have enclosed it in "git-format-patch" format.




(file #27297)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-Ugly-but-working-fix-for-bug-38084.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?38084>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/