[Gnash-commit] [bug #45887] `gnash --audio-dump` produces corrupted WAV file

[Nutchanon Wetchasit]

Follow-up Comment #3, bug #45887 (project gnash):

After I looked around `libsound/WAVWriter.cpp`, I found following problems:
* `WAVWriter::write_wave_header()` uses a wrong size for `RIFF` chunk
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6#n116>
(it does not correctly exclude 8 bytes of "RIFF" string and its chunk size
field). This seems to be an origin of the mysterious 8-byte invalid chunk.
* `WAVWriter` does not flush metadata when closing the stream
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6#n78>.
(The main issue of this bug)

Other minor issues found are:
* `WAVWriter.write_wave_header()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6#n123>
and `WAVWriter.pushSamples()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6#n86>
does not use an endian-neutral way to write bytes. (These will break on
big-endian system)
* Audio dump notice message is incorrect
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6#n70>.
It should be "Created 44100 Hz 16-bit stereo wave file:".
* Audio dump notice message was written directly to `stdout`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6#n70>,
rather than a `log_debug()` or similar facility.

Gnash: 0.8.11dev (git dc51f53 28-Aug-2015)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/