[Gnash-commit] [patch #8734] Patches for improving `--audio-dump` support in Gnash

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8734>

                 Summary: Patches for improving `--audio-dump` support in
Gnash
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Mon 07 Sep 2015 04:31:43 PM ICT
                Category: sound
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Gnash's support for `--audio-dump`/`-A` option have some problems that
rendered output file unreadable by several program. This narrowed down to
how Gnash writes RIFF WAVE metadata in `libsound/WAVWriter.cpp`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libsound/WAVWriter.cpp?id=dc51f5389e4726486b631864151dcfe28e556cf6>.

Attached patch (patch 1 of 4: `0001_use-correct-riff-wave-chunk-size.patch`)
addresses the issue of a wrong RIFF chunk size in output WAVE file. (Which
was
originally off-by-8 because "RIFF" string and its chunk size field was
erroneously included in the count
<https://savannah.gnu.org/bugs/?45887#comment3>).

This partially fixes bug #45887.

Gnash: 0.8.11dev (patched against git dc51f53 28-Aug-2015)
System: Debian GNU/Linux 7.0 Wheezy i386



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 07 Sep 2015 04:31:44 PM ICT  Name:
0001_use-correct-riff-wave-chunk-size.patch  Size: 630B   By: nachanon
Patch to correct RIFF chunk size in WAVE dump file
<http://savannah.gnu.org/patch/download.php?file_id=34823>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8734>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/