[Gnash-commit] [bug #46131] Gnash's `ExternalInterface.call()` did not correctly pass return value from JavaScript function

[Nutchanon Wetchasit]

Follow-up Comment #4, bug #46131 (project gnash):

Patch included, see patch #8765.

This is a trace log from `flash2js.html` after applied the patch:
+verbose+
67 ACTIONSCRIPT ERROR: reference to non-existent variable 'Flash2JS'
67 TRACE: flash2js: calling JavaScript function "flash_call"...
68 TRACE: flash2js: OK: JavaScript function correctly returned "Too"
-verbose-
You'd see that the return value from JavaScript is now propagated back
to ActionScript correctly.

This is a trace log from `flash2js-multi.html` after applied the patch:
+verbose+
65 ACTIONSCRIPT ERROR: reference to non-existent variable 'MultiFlash2JS'
67 TRACE: flash2js-multi: 1: OK: JavaScript function correctly returned "one"
67 TRACE: flash2js-multi: 2: OK: JavaScript function correctly returned "two"
68 TRACE: flash2js-multi: 3: OK: JavaScript function correctly returned
"three"
68 TRACE: flash2js-multi: 4: OK: JavaScript function correctly returned
"four"
69 TRACE: flash2js-multi: 5: OK: JavaScript function correctly returned
"five"
69 TRACE: flash2js-multi: 6: OK: JavaScript function correctly returned "six"
70 TRACE: flash2js-multi: 7: OK: JavaScript function correctly returned
"seven"
70 TRACE: flash2js-multi: 8: OK: JavaScript function correctly returned
"eight"
71 TRACE: flash2js-multi: 9: OK: JavaScript function correctly returned
"nine"
71 TRACE: flash2js-multi: 10: OK: JavaScript function correctly returned
"ten"
72 TRACE: flash2js-multi: 11: OK: JavaScript function correctly returned
"eleven"
72 TRACE: flash2js-multi: 12: OK: JavaScript function correctly returned
"twelve"
73 TRACE: flash2js-multi: 13: OK: JavaScript function correctly returned
"thirteen"
73 TRACE: flash2js-multi: 14: OK: JavaScript function correctly returned
"fourteen"
74 TRACE: flash2js-multi: 15: OK: JavaScript function correctly returned
"fifteen"
74 TRACE: flash2js-multi: 16: OK: JavaScript function correctly returned
"sixteen"
75 TRACE: flash2js-multi: 17: OK: JavaScript function correctly returned
"seventeen"
75 TRACE: flash2js-multi: 18: OK: JavaScript function correctly returned
"eighteen"
76 TRACE: flash2js-multi: 19: OK: JavaScript function correctly returned
"nineteen"
77 TRACE: flash2js-multi: 20: OK: JavaScript function correctly returned
"twenty"
-verbose-

You'd see that all JavaScript return values are now correctly matched
its corresponding ExternalInterface call.

Note: There are more issues related to how Gnash (player) interprets
return value on special cases (like function that does not return value),
so this bug is not fully fixed yet.

Gnash: 0.8.11dev (patched against git f0f66ce 23-Sep-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46131>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/