gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [bug #46131] Gnash's `ExternalInterface.call()` did not c


From: Nutchanon Wetchasit
Subject: [Gnash-commit] [bug #46131] Gnash's `ExternalInterface.call()` did not correctly pass return value from JavaScript function
Date: Fri, 09 Oct 2015 09:21:55 +0000
User-agent: Mozilla/5.0 (X11; Linux i686; rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0

Follow-up Comment #3, bug #46131 (project gnash):

According to `doc/changelogs/ChangeLog-0.8.9`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/doc/changelogs/ChangeLog-0.8.9?id=f0f66ce7f644a631bbb5f51f78375298fdef3d40#n3047>,
this nonblocking behavior of
`ExternalInterface::readBrowser()` seems to be introduced by fe4faf3
<http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=fe4faf34f62b8ead1c5c48fa2d426e99fbd6c46a>
in 0.8.9dev line, possibly to prevent freezes.

I think one way to fix this, is to re-introduce the old behavior of
`ExternalInterface::readBrowser()` that blocks until the expected data
is available _or specified time runs out_. (Gnash is supposed to wait for
the answer from browser as long as it takes, the timeout is just a
last-resort safeguard)

Fixing it this way shouldn't cause other problem as this method is not used
by any other code in Gnash.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46131>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]