[Gnash-commit] [patch #8914] Patches to improve exception handling in Gnash's ExternalInterface callback

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8914>

                 Summary: Patches to improve exception handling in Gnash's
ExternalInterface callback
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sat 20 Feb 2016 01:31:10 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a follow-up to patch #8909 (ExternalInterface in-band error fix).

Current Gnash (player) have a special-case return value check on
ExternalInterface callback invocation
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=051aa9c34b69e1a0a1d2d75e3cf1db07fcea4006#n1964>.
This caused legitimate `null` return
value from the callback to be changed to an in-band error signal
<https://savannah.gnu.org/bugs/?47004#comment12>
indistinguishable from normal "Error" string return value.

Patch 1 of 2:
See the attached
`0005_externalinterface-callback-drop-inband-error-generation.patch`.

This patch removes the check, so that `null` return value from the callback
could be correctly passed to host container, partially fixing bug #47004.

Gnash: 0.8.11dev (patched against git 051aa9c 15-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 20 Feb 2016 01:31:10 PM ICT  Name:
0005_externalinterface-callback-drop-inband-error-generation.patch  Size: 868B
  By: nachanon
Patch to drop in-band error code generation on `null` return value of
ExternalInterface callback
<http://savannah.gnu.org/patch/download.php?file_id=36406>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8914>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/