[Gnash-commit] [patch #8914] Patches to improve exception handling in Gnash's ExternalInterface callback

[Nutchanon Wetchasit]

Follow-up Comment #1, patch #8914 (project gnash):

Current Gnash (player)'s ExternalInterface callback handler employs an
in-band error code detection
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=051aa9c34b69e1a0a1d2d75e3cf1db07fcea4006#n1683>
to log callback failure on debug channel.
This caused an error message to be logged when the callback legitimately
returned "Error" or "SecurityError" string
<https://savannah.gnu.org/bugs/?47004#comment11>.

Although this does not affect outcome of the operation (return value is
already sent to the container), it causes confusion and pollutes debug log.

Patch 2 of 2:
See the attached `0006_externalinterface-drop-error-string-check-msg.patch`.

This patch removes the check, so that normal "Error" or "SecurityError"
string
return value from ExternalInterface callback is not mistakenly flagged as
a callback failure, fixing bug #47004.

Gnash: 0.8.11dev (patched against git 051aa9c 15-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy


(file #36407)
    _______________________________________________________

Additional Item Attachment:

File name: 0006_externalinterface-drop-error-string-check-msg.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8914>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/