[Gnash-commit] [bug #47004] Gnash didn't pass string return value "Error" and "SecurityError" from ExternalInterface callback

[Nutchanon Wetchasit]

Follow-up Comment #13, bug #47004 (project gnash):

Patch included for fixing `null` return value and incorrect error messages;
see patch #8914.

This is text output of `js2flash-errorstring.html` on browser with patched
Gnash:

Flash's error_call() returned type string, value: Error
Flash's securityerror_call() returned type string, value: SecurityError
Flash's hello_call() returned type string, value: Hello!


Debug log (verbosity 1 + action error) from the run:

87 SECURITY: Extensions disabled
88 UNIMPLEMENTED: FileAttributes tag in the SWF requests that network access
is not granted to this movie (or application?) when loaded from the
filesystem. Anyway Gnash won't care; use white/black listing in your .gnashrc
instead
89 TRACE: callee: finished initializing
2931 TRACE: callee: error_call callback invoked
2941 TRACE: callee: securityerror_call callback invoked
2951 TRACE: callee: hello_call callback invoked


You'd see that there are no "ERROR: Couldn't process ExternalInterface
Call..."
message appearing after `error_call()` and `securityerror_call()` callback
invocation anymore.

This is text output of `js2flash-rtypes.html` on browser with patched Gnash:

PASSED: Flash should properly register string_call callback
PASSED: Flash should properly register error_call callback
PASSED: Flash should properly register securityerror_call callback
PASSED: Flash should properly register integer_call callback
PASSED: Flash should properly register float_call callback
PASSED: Flash should properly register infinite_call callback
PASSED: Flash should properly register neginfinite_call callback
PASSED: Flash should properly register nan_call callback
PASSED: Flash should properly register boolean_call callback
PASSED: Flash should properly register null_call callback
PASSED: Flash should properly register noret_call callback
PASSED: Flash should properly register undefined_call callback
PASSED: Flash should properly register exception_call callback
PASSED: Flash should properly register array_call callback
PASSED: Flash should properly register object_call callback
PASSED: Flash should properly register object_customstring_call callback
PASSED: Flash should properly register object_customvalue_call callback
PASSED: Flash should properly register function_call callback
PASSED: Flash callback script_call should return a correct type
PASSED: Flash callback script_call should return a correct value
PASSED: Flash callback error_call should return a correct type
PASSED: Flash callback error_call should return a correct value
PASSED: Flash callback securityerror_call should return a correct type
PASSED: Flash callback securityerror_call should return a correct value
PASSED: Flash callback integer_call should return a correct type
PASSED: Flash callback integer_call should return a correct value
PASSED: Flash callback float_call should return a correct type
PASSED: Flash callback float_call should return a correct value
PASSED: Flash callback infinite_call should return a correct type
FAILED: Flash callback infinite_call should return a correct value ("0" !=
"Infinity")
PASSED: Flash callback neginfinite_call should return a correct type
FAILED: Flash callback neginfinite_call should return a correct value ("0" !=
"-Infinity")
PASSED: Flash callback nan_call should return a correct type
FAILED: Flash callback nan_call should return a correct value
PASSED: Flash callback boolean_call should return a correct type
PASSED: Flash callback boolean_call should return a correct value
PASSED: Flash callback null_call should return a correct type
PASSED: Flash callback null_call should return a correct value
PASSED: Flash callback noret_call should return a correct type
PASSED: Flash callback noret_call should return a correct value
PASSED: Flash callback undefined_call should return a correct type
PASSED: Flash callback undefined_call should return a correct value
PASSED: Flash callback exception_call should return a correct type
PASSED: Flash callback exception_call should return a correct value
FAILED: Flash callback array_call should return a correct type ("function" !=
"object")
FAILED: Flash callback array_call should return an object of Array class
FAILED: Flash callback array_call should return an array with correct size
("undefined" != "9")
FAILED: Flash callback array_call should return an array with correct element
0 ("undefined" != "The")
FAILED: Flash callback array_call should return an array with correct element
1 ("undefined" != "quick")
FAILED: Flash callback array_call should return an array with correct element
2 ("undefined" != "brown")
FAILED: Flash callback array_call should return an array with correct element
3 ("undefined" != "fox")
FAILED: Flash callback array_call should return an array with correct element
4 ("undefined" != "jumps")
FAILED: Flash callback array_call should return an array with correct element
5 ("undefined" != "over")
FAILED: Flash callback array_call should return an array with correct element
6 ("undefined" != "the")
FAILED: Flash callback array_call should return an array with correct element
7 ("undefined" != "lazy")
FAILED: Flash callback array_call should return an array with correct element
8 ("undefined" != "dog")
ERROR: Error: Error calling method on NPObject!


You'd see that return value from `null_call()` ExternalInterface callback
is now correctly seen from JavaScript as `null`.

Other failures regarding numeric return values are remaining
to be investigated, possibly as a separate report.

Gnash: 0.8.11dev (patched against git 051aa9c 15-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47004>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/