[Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function

[Nutchanon Wetchasit]

Follow-up Comment #2, patch #9234 (project gnash):

There might be errors in my patch, but that should not prevent the relevant
tests from being run. The SWF by itself should emit three `PASSED` lines
followed by `ENDOFTEST` in Flash's trace output.

My compilation procedure is as follows:

$ git clean -xdf
$ git checkout -f
Your branch is ahead of 'origin/master' by 1 commit.
$ ./autogen.sh
Running libtoolize --force --copy ...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `macros'.
libtoolize: copying file `macros/libtool.m4'
libtoolize: copying file `macros/ltoptions.m4'
libtoolize: copying file `macros/ltsugar.m4'
libtoolize: copying file `macros/ltversion.m4'
libtoolize: copying file `macros/lt~obsolete.m4'
processing .
Running aclocal -I cygnal -I macros  ...
Running autoheader...
Running automake --add-missing --copy  ...
configure.ac:35: installing `./compile'
configure.ac:25: installing `./config.guess'
configure.ac:25: installing `./config.sub'
Running autoconf ...
$ CC="ccache gcc" CXX="ccache g++" ./configure --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
.
.
(Output omitted)
.
.
        Building Cygnal media server disabled.
        Extension support disabled.
        Enabling security features:  localconnection
        Enabling statistics collecting for:  cache
        GUI toolkits supported: fb,qt4,gtk,sdl,dump
        Renderers supported:  agg cairo opengl
        Hardware Acceleration: RawFB
        Media handlers: ffmpeg gst 
        Using sdl for sound handling
        DocBook document processing enabled (for "make html" and "make pdf")
        Docbook styles sheets in /usr/share/xml/docbook/stylesheet/nwalsh
        Using Input Devices, Touchscreen via Tslib for Input
        Using double buffering when rendering
 
$ cd testsuite/misc-swfc.all
$ make submoviegetvar.swf
ccache gcc -E -x c -P -undef -I.
-DMEDIADIR="/home/window/prog/gnash.git/testsuite/media " submoviegetvar.sc >
pp_submoviegetvar.sc 
/usr/bin/swfc  -o submoviegetvar.swf pp_submoviegetvar.sc
$ file submoviegetvar.swf
submoviegetvar.swf: Macromedia Flash data (compressed), version 7
$ 


Trace output from Flash Player runnning `submoviegetvar.swf` is as follows:

Warning: Reference to undeclared variable, 'undefined'
PASSED:  [submoviegetvar.sc:40]
Warning: Reference to undeclared variable, 'undefined'
PASSED:  [submoviegetvar.sc:46]
Warning: Reference to undeclared variable, 'undefined'
PASSED:  [submoviegetvar.sc:52]
ENDOFTEST


I have attached my compiled version of SWF as `submoviegetvar.swf`.

Note: These `PASSED` lines are sanity checks. Real tests are done
by the external test runner.

Gnash testsuite: 0.8.11dev (patched against git 2b3bded 21-Jul-2016)
Flash Player: 11.2.202.491 (NPAPI binary)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39554)
    _______________________________________________________

Additional Item Attachment:

File name: submoviegetvar.swf             Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9234>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/