[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #9234] Patch for adding automated slash-colon path
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function |
Date: |
Wed, 25 Jan 2017 10:30:30 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1 |
Follow-up Comment #4, patch #9234 (project gnash):
For the errors I mentioned <https://savannah.gnu.org/patch/?9234#comment2>
about my patch:
* I used DejaGNU's `check()` function incorrectly; it should be `check(true)`
instead of plain `check()`.
* I didn't track `Dejagnu.sc` and `check.sc` dependency of `submoviegetvar.sc`
in `Makefile`.
Updated patch which fixes these issues, is attached as
`0006_add-slashcolon-getvariable-test-v2.patch`.
My compiled SWF from this patch is attached as `submoviegetvar-v2.zip`,
and can be used together with the previously-posted `submoviegetvar.html`
(file #39555); browser-shown test results should be the same.
Browser output of my `submoviegetvar.html` test run with updated patch
went like this (using Flash Player):
PASSED: GetVariable call on "movievar" path should return a correct value
XPASSED: GetVariable call on ":movievar" path should return a correct value
PASSED: GetVariable call on "/:movievar" path should return a correct value
PASSED: GetVariable call on "submovie:submovievar" path should return a
correct value
PASSED: GetVariable call on "submovie/:submovievar" path should return a
correct value
PASSED: GetVariable call on "submovie::submovievar" path should return a
correct value
PASSED: GetVariable call on "/submovie:submovievar" path should return a
correct value
PASSED: GetVariable call on "/submovie/:submovievar" path should return a
correct value
PASSED: GetVariable call on "/submovie::submovievar" path should return a
correct value
PASSED: GetVariable call on ":submovie:submovievar" path should return a
correct value
PASSED: GetVariable call on ":submovie/:submovievar" path should return a
correct value
PASSED: GetVariable call on ":submovie::submovievar" path should return a
correct value
PASSED: GetVariable call on "submovie/nestedmovie:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "submovie/nestedmovie/:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "submovie/nestedmovie::nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "submovie:nestedmovie:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "submovie:nestedmovie/:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "submovie:nestedmovie::nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "/submovie/nestedmovie:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "/submovie/nestedmovie/:nestedmovievar" path
should return a correct value
PASSED: GetVariable call on "/submovie/nestedmovie::nestedmovievar" path
should return a correct value
PASSED: GetVariable call on "/submovie:nestedmovie:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on "/submovie:nestedmovie/:nestedmovievar" path
should return a correct value
PASSED: GetVariable call on "/submovie:nestedmovie::nestedmovievar" path
should return a correct value
PASSED: GetVariable call on ":submovie/nestedmovie:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on ":submovie/nestedmovie/:nestedmovievar" path
should return a correct value
PASSED: GetVariable call on ":submovie/nestedmovie::nestedmovievar" path
should return a correct value
PASSED: GetVariable call on ":submovie:nestedmovie:nestedmovievar" path should
return a correct value
PASSED: GetVariable call on ":submovie:nestedmovie/:nestedmovievar" path
should return a correct value
PASSED: GetVariable call on ":submovie:nestedmovie::nestedmovievar" path
should return a correct value
And this is Flash Player trace log from the run:
Warning: Reference to undeclared variable, 'undefined'
PASSED: [submoviegetvar.sc:40]
Warning: Reference to undeclared variable, 'undefined'
PASSED: [submoviegetvar.sc:46]
Warning: Reference to undeclared variable, 'undefined'
PASSED: [submoviegetvar.sc:52]
ENDOFTEST
Gnash testsuite: 0.8.11dev (patched against git 2b3bded 21-Jul-2016)
Flash Player: 11.2.202.491 (NPAPI binary)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
(file #39556, file #39557)
_______________________________________________________
Additional Item Attachment:
File name: 0006_add-slashcolon-getvariable-test-v2.patch Size:13 KB
File name: submoviegetvar-v2.zip Size:1 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?9234>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/23
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Sandro Santilli, 2017/01/24
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/25
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/25
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function,
Nutchanon Wetchasit <=
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/25
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Sandro Santilli, 2017/01/25
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Karla, 2017/01/26
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/27
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Sandro Santilli, 2017/01/28
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/28
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Nutchanon Wetchasit, 2017/01/29
- [Gnash-commit] [patch #9234] Patch for adding automated slash-colon path checks on `GetVariable()` plugin function, Sandro Santilli, 2017/01/30