Re: gnats/108

[Steffen Opel]

The following reply was made to PR gnats/108; it has been noted by GNATS.

From: "Steffen Opel" <address@hidden>
To: <address@hidden>,
        <address@hidden>,
        <address@hidden>
Cc:  
Subject: Re: gnats/108
Date: Fri, 20 Oct 2000 15:10:12 +0200

 http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%26pr=108%26database=g
 nats
 
 After further investigation I have neither found a replacement nor believe
 one is useful but
 rather think it has indeed just been broken as Bob Manson oulined in the
 ChangeLog for
 CVS revision 1.46:
 
         * gnatsd.c: Clean up authentication code a bit; all user
         authentication is now verified when a CHDB is done.  Changing to
         the initial database is now done via gnatsdChdb ().  The
         authentication is probably now broken, however.
 
 Hence I've just put it in again, adapted to new return value scheme, see fix
 below; this means
 clients such as gnatsweb still needs to be adapted (because they shouldn't
 rely on return
 messages anymore in contrast to return values) but at least are able to
 retrieve what's needed.
 
 index: gnats/cmds.c
 ===================================================================
 RCS file: /cvs/gnats/gnats/gnats/cmds.c,v
 retrieving revision 1.49
 diff -c -r1.49 cmds.c
 *** cmds.c      2000/08/15 00:12:39     1.49
 --- cmds.c      2000/10/20 12:53:45
 ***************
 *** 324,331 ****
   {
     ErrorDesc err;
 
 !   if (ac == 2)
       {
         if (databaseValid (currentDatabase))
         {
           if (gnatsdChdb (databaseName (currentDatabase), av[0], av[1], 0,
 --- 324,338 ----
   {
     ErrorDesc err;
 
 !   if (ac == 0)
       {
 +        printf ("%d-The current user access level is:\r\n",
 +                CODE_INFORMATION_FILLER);
 +        printf ("%d %s\r\n", CODE_INFORMATION,
 +                access_level_str (user_access));
 +     }
 +   else if (ac == 2)
 +     {
         if (databaseValid (currentDatabase))
         {
           if (gnatsdChdb (databaseName (currentDatabase), av[0], av[1], 0,
 Index: gnats/ChangeLog
 ===================================================================
 RCS file: /cvs/gnats/gnats/gnats/ChangeLog,v
 retrieving revision 1.159
 diff -c -r1.159 ChangeLog
 *** ChangeLog   2000/08/23 19:55:22     1.159
 --- ChangeLog   2000/10/20 12:53:46
 ***************
 *** 1,3 ****
 --- 1,8 ----
 + 2000-10-20  Steffen Opel  <address@hidden>
 +
 +       * cmds.c (GNATS_user): Reenable documented USER access level
 +       return value if issued without arguments.
 +
   Wed Aug 23 12:49:59 2000  Bob Manson  <address@hidden>
 
         * pr.c (verifyMultiEnum): Accept NULL values if the field doesn't