gnats/115: Internal call to 'query-pr' from 'at-pr' fails with expected results

[opel]

>Number:         115
>Category:       gnats
>Synopsis:       Internal call to 'query-pr' from 'at-pr' fails with expected 
>results
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 23 19:44:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Steffen Opel
>Release:        gnats-4.0-alpha
>Organization:
>Environment:
Linux gg.geekgadgets.org 2.2.16-22 #1 Tue Aug 22 16:49:06 EDT 2000 i686 unknown
>Description:
'at-pr' calls 'query-pr' internally in order to verify field requirements etc. 
Since 'query-pr' isn't in the PATH this call fails with expected results, see 
fix below and related PR 113. 
>How-To-Repeat:
Setup notification on expired PRs in a default installation (which places 
queue-pr in /usr/local/bin), this will trigger the problem.
>Fix:
Index: gnats/Makefile.in
===================================================================
RCS file: /cvs/gnats/gnats/gnats/Makefile.in,v
retrieving revision 1.36
diff -c -r1.36 Makefile.in
*** Makefile.in 2000/08/02 21:46:18     1.36
--- Makefile.in 2000/10/24 01:53:23
***************
*** 248,253 ****
--- 248,254 ----
        @sed -e 's,xVERSIONx,$(VERSION),g' \
            -e 's,xGNATS_DEFAULT_DB_DIRx,$(GNATS_DEFAULT_DB_DIR),g' \
            -e 's,xGNATS_USERx,$(GNATS_USER),g' \
+           -e 's,xBINDIRx,$(bindir),g' \
            -e 's,xLIBEXECDIRx,$(libexecdir),g' $(srcdir)/at-pr.sh > 
address@hidden
        @mv address@hidden $@
        @chmod a+x $@
Index: gnats/at-pr.sh
===================================================================
RCS file: /cvs/gnats/gnats/gnats/at-pr.sh,v
retrieving revision 1.3
diff -c -r1.3 at-pr.sh
*** at-pr.sh    1999/12/22 04:44:23     1.3
--- at-pr.sh    2000/10/24 01:53:23
***************
*** 33,39 ****
   7 - address for GNATS_ADMIN
  "
  
! PATH=/bin:/usr/bin; export PATH
  
  if [ $# -eq 0 ]
  then
--- 33,40 ----
   7 - address for GNATS_ADMIN
  "
  
! PATH=xBINDIRx:/bin:/sbin:/usr/bin:/usr/ucb:/usr/bsd:/usr/sbin
! export PATH
  
  if [ $# -eq 0 ]
  then
Index: gnats/ChangeLog
===================================================================
RCS file: /cvs/gnats/gnats/gnats/ChangeLog,v
retrieving revision 1.159
diff -c -r1.159 ChangeLog
*** ChangeLog   2000/08/23 19:55:22     1.159
--- ChangeLog   2000/10/24 01:53:23
***************
*** 1,3 ****
--- 1,11 ----
+ 2000-10-24  Steffen Opel  <address@hidden>
+
+       * at-pr.sh (PATH): Fixed in order to find query-pr.
+       * Makefile.in (at-pr): Substitute BINDIR.
+
  Wed Aug 23 12:49:59 2000  Bob Manson  <address@hidden>

        * pr.c (verifyMultiEnum): Accept NULL values if the field doesn't
>Release-Note:
>Audit-Trail:
>Unformatted: