Re: [gnokii-0.5.0rc1] Sucess & Proposal for patch

[Pawel Kot]

>>> address@hidden 30 March 2003 03:10:31 >>>
> a) I would like to propose the small attached ("u8.patch"):
> - API u8 gn_ringtone_pack(gn_ringtone *ringtone, unsigned char
*package, int *maxlength); 
> +API unsigned char gn_ringtone_pack(gn_ringtone *ringtone, unsigned
char *package, int *maxlength)
> it makes it a little easier portable and don't forces me to include
other headers.
> Please remember, I don't include GTK or Gnome libs....

Yep. This is already in CVS (I hope this time for sure).

> b) Maybe you could add the patch "version.patch" or a similiar one
too ? 
> It adds MAJOR/MINOR version numbers to gnokii.h, which makes it maybe
later 
> more easy to distiguish between different libgnokii versions at
runtime ?

Yeah, it looks sane. I'll either use the solution you proposed or will
try to generate
it automatically from VERSION file.

> c) In the file common/devices/unixserial.c, line 430, you use
"exit(EXIT_FAILURE);" 
> which is really ugly in a library. My tool is dlopen()'d by the
KAddressbook, and when 
> exit() is called, KAddressbook will be closed at once and it looks
for the user as 
> it crashed. Isn't there any possibility to return a failure-value
back to the caller instead, 
> and then he could then call exit() if necessary.. ?

Agreed. Will fix it.

pkot