Re: 6610 Follow-up... Re: gnokii --getsms doesn't work

[BORBELY Zoltan]

Hi,

On Thu, Oct 09, 2003 at 07:43:40PM -0400, Michael H. Warfield wrote:
>       I made this one change to nk6510.c and it's consistently reading
> the folders properly.
> 
> Line 842 common/phones/nk6510.c
> 
> 
> -                         i = 10 + (j * 40);      // 6510
> +//                       i = 10 + (j * 40);      // 6510
> +                         i = 10 + (j * 88);      // 6610
>                           data->sms_folder_list->folder_id[j] = message[i - 
> 2];
>                           dprintf("Folder(%i) name: ", message[i - 2]);
>                           len = message[i - 1] << 1;
>                           
> char_unicode_decode(data->sms_folder_list->folder[j].name, message + i, len);
>                           dprintf("%s\n", 
> data->sms_folder_list->folder[j].name);

You're right. Thanks for spotting this out.

>       Much better.  Means there are difference between the 6610 and the
> 6510 that need to be recognized and I'll bet this isn't the only one.
> But it's a start.  Someone will need to figure out how to code that to
> switch between the two.

It seems the GetSMSFolders reply message was decoded improperly. It seems
this message is built from blocks where each block contains its length.
This was expected as a constant (0x28 - 40!) in the protocol description:

http://savannah.nongnu.org/cgi-bin/viewcvs/gnokii/gnokii/Docs/protocol/nk6510.txt.diff?r1=1.7&r2=1.8&diff_format=h

I applied a more elegant fix, please test it! :-)

http://savannah.nongnu.org/cgi-bin/viewcvs/gnokii/gnokii/common/phones/nk6510.c.diff?r1=1.121&r2=1.122

>       Hope there's not TOO many more of these (xgnokii still doesn't
> seem to happy - cycling on refreshing SMS and never filling in the INBOX).

Try to create a debug output and send it (or the url) to us.

Bye,
Bozo