[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnu-arch-users] Re: Re: Having two precommit hooks
From: |
Mikhael Goikhman |
Subject: |
Re: [Gnu-arch-users] Re: Re: Having two precommit hooks |
Date: |
Mon, 11 Oct 2004 17:48:45 +0000 |
User-agent: |
Mutt/1.4.2.1i |
On 11 Oct 2004 09:24:06 -0700, Thomas Lord wrote:
>
> > From: Anand Kumria <address@hidden>
>
> > Basically I think you need four hooks for commit:
> > - pre-commit-changeset (tree modifications allowed, reformat
> code)
> > - post-commit-changeset (no modifications allowed, ?)
> > - pre-commit (no modifications allowed, run test suites)
> > - post-commit (send notifications)
>
> > In some sense you could combine post-commit-changeset and pre-commit
> > together; my thought is that post-commit-changeset could be used to
> clean
> > up after pre-commit-changeset. In most cases it would not be necessary
> > but you never know.
>
> I think they should be combined (the existing pre-commit hook is
> sufficient).
So, returning to the original message that started this subject,
do you think the following hook names are intuitive enough:
* prepare-commit
* confirm-commit
* post-commit
I would avoid precommit, pre-precommit and commit names as ambiguous.
Regards,
Mikhael.
- Re: [Gnu-arch-users] Re: Having two precommit hooks, (continued)
- Re: [Gnu-arch-users] Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Having two precommit hooks, Harald Meland, 2004/10/11
- Re: [Gnu-arch-users] Re: Having two precommit hooks, Thomas Lord, 2004/10/12
- Re: [Gnu-arch-users] Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Having two precommit hooks, James Blackwell, 2004/10/12
- [Gnu-arch-users] Re: Re: Having two precommit hooks, Anand Kumria, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks,
Mikhael Goikhman <=
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Stephen J. Turnbull, 2004/10/11
- [Gnu-arch-users] Re: Re: Re: Having two precommit hooks, Anand Kumria, 2004/10/13
- Re: [Gnu-arch-users] Having two precommit hooks, John Meinel, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, David Allouche, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, David Allouche, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, John Meinel, 2004/10/10
- [Gnu-arch-users] tla front-ends, David Allouche, 2004/10/10
- [Gnu-arch-users] Re: tla front-ends, Matthieu Moy, 2004/10/10
- Re: [Gnu-arch-users] tla front-ends, John Meinel, 2004/10/10