[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnu-arch-users] Re: Re: Re: Having two precommit hooks
From: |
Anand Kumria |
Subject: |
[Gnu-arch-users] Re: Re: Re: Having two precommit hooks |
Date: |
Thu, 14 Oct 2004 00:11:27 +1000 |
User-agent: |
Pan/0.14.2.91 (As She Crawled Across the Table (Debian GNU/Linux)) |
On Mon, 11 Oct 2004 11:36:18 -0700, Thomas Lord wrote:
>
> > From: Mikhael Goikhman <address@hidden>
>
> > So, returning to the original message that started this subject,
> > do you think the following hook names are intuitive enough:
>
> > * prepare-commit
> > * confirm-commit
> > * post-commit
>
> > I would avoid precommit, pre-precommit and commit names as ambiguous.
>
> I don't like the idea of changing the existing names which, while
> perhaps not ideal, aren't really that bad.
>
> How about:
>
> prepare-commit
> precommit
> commit
>
> ? The (made up here) guiding principle being that hooks named after
> commands are called after the command completes ("commit") and that
Isn't the hook already called post-commit? Are you suggesting a name
change, or a 'if I could redo tla, I'd ....'?
> the last hook called before beginning an archive transaction is the
> command name prefixed with "pre" ("precommit"), and that if the
> command operates on a tree and we want a hook that gets first-shot on
> that tree, that's "prepare-" followed by the command name.
Sounds good; so in the general case an hook that looks like 'prepare-' can
modify the tree however it wants - no other hook can though.
Cheers,
Anand
--
linux.conf.au 2005 - http://lca2005.linux.org.au/ - Birthplace of Tux
April 18th to 23rd - http://lca2005.linux.org.au/ - LINUX
Canberra, Australia - http://lca2005.linux.org.au/ - Get bitten!
- Re: [Gnu-arch-users] Re: Having two precommit hooks, (continued)
- Re: [Gnu-arch-users] Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Having two precommit hooks, James Blackwell, 2004/10/12
- [Gnu-arch-users] Re: Re: Having two precommit hooks, Anand Kumria, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Mikhael Goikhman, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Thomas Lord, 2004/10/11
- Re: [Gnu-arch-users] Re: Re: Having two precommit hooks, Stephen J. Turnbull, 2004/10/11
- [Gnu-arch-users] Re: Re: Re: Having two precommit hooks,
Anand Kumria <=
- Re: [Gnu-arch-users] Having two precommit hooks, John Meinel, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, David Allouche, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, David Allouche, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, John Meinel, 2004/10/10
- [Gnu-arch-users] tla front-ends, David Allouche, 2004/10/10
- [Gnu-arch-users] Re: tla front-ends, Matthieu Moy, 2004/10/10
- Re: [Gnu-arch-users] tla front-ends, John Meinel, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, Miles Bader, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, Miles Bader, 2004/10/10
- Re: [Gnu-arch-users] Having two precommit hooks, James Blackwell, 2004/10/10