Re: [gnugo-devel] 3.0 portability problem

[Gunnar Farneback]

Teun wrote:
> we could also test for SIZEOF_INT > 4
> SIZEOF_INT is already set by configure in config.h.

This is exactly why I wrote

> This can be solved either by including config.h in random.c or by
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> applying the following patch, which I think is a better solution.

The replaced code looked like this

  #if (CHAR_BIT * SIZEOF_INT > 32)

which is the correct way of doing this, although platforms with
CHAR_BIT != 8 are kind of rare today. But I still think my patch is
better because it gives a robust test which doesn't require including
config.h. The reason why this is to prefer is that a random number
generator is completely standalone and potentially useful for other
projects, so the fewer dependencies it has, the better.

/Gunnar