Re: [gnugo-devel] configure.in and enable-dfa

[Teun Burgers]

Gunnar Farneback wrote:
> 
> Teun wrote:
> > > I wasn't convinced by the two reasons you gave for the
> > > change but Gunnar's opinion was that there isn't much
> > > penalty for making this change and that it generally cleans
> > > up the code not to have these ifdefs.
> >
> > Fine! So we crossed this hurdle.
> 
> I might have been somewhat wrong because now I can't build without dfa
> at all. The problem is that the linking of mkpat fails because it's
> missing a number of symbols from dfa.

You're right. We need a few more changes to Makefile.ams.
See the attached patch.

> It looks to me like
> mkpat_LDADD must include libdfa.a also when DFA_ENABLED is false. Do
> we even need a separate libdfa.a any more?

I guess so. gnugo is also linked with libdfa.a

Teun

Index: interface/Makefile.am
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/Makefile.am,v
retrieving revision 1.4
diff -u -r1.4 Makefile.am
--- interface/Makefile.am       2001/10/17 20:34:15     1.4
+++ interface/Makefile.am       2001/11/10 11:45:11
@@ -14,24 +14,12 @@
        -I$(top_srcdir)/engine \
        -I$(top_srcdir)/utils
 
-if DFA_ENABLED
-
 LDADD = \
        ../engine/libengine.a \
        ../patterns/libpatterns.a \
        ../patterns/libdfa.a \
        ../sgf/libsgf.a \
        ../utils/libutils.a
-
-else
-
-LDADD = \
-       ../engine/libengine.a \
-       ../patterns/libpatterns.a \
-       ../sgf/libsgf.a \
-       ../utils/libutils.a
-
-endif
 
 gnugo_SOURCES = \
        main.c \
Index: patterns/Makefile.am
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/Makefile.am,v
retrieving revision 1.5
diff -u -r1.5 Makefile.am
--- patterns/Makefile.am        2001/09/26 15:31:32     1.5
+++ patterns/Makefile.am        2001/11/10 11:45:15
@@ -29,10 +29,10 @@
 
 mkpat_SOURCES  = mkpat.c transform.c
 
-if DFA_ENABLED
-
 mkpat_LDADD = ./libdfa.a ../utils/libutils.a
 
+if DFA_ENABLED
+
 # dfas in DFA_INST are made and installed in $prefix/share/gnugo
 
 DFA_INST = \
@@ -70,7 +70,6 @@
 # fusekipat.dfa: fuseki.c
 
 else
-mkpat_LDADD = ../utils/libutils.a
 DFAFLAGS =
 endif
 transpat_SOURCES = transpat.c patlib.c transform.c