gnulib-tool-py
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnulib-tool-py] GLModule or GLModuleSystem class


From: Bruno Haible
Subject: Re: [gnulib-tool-py] GLModule or GLModuleSystem class
Date: Sun, 24 Jun 2012 19:49:10 +0200
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

Hi Dmitriy,

> am I right that func_verify_module should return path to file which
> returns from func_lookup_file?

As an optimization, it could do so.

In the old gnulib-tool, the purpose of this function is to emit a warning
and set the 'module' variable to empty, simply to signal when the module
description cannot be found or patched.

In the new one, the corresponding method could return a GLModule object,
and this object could have two fields that correspond to
  - lookedup_file   name of the merged (combined) module description file
  - lookedup_tmp    true if it is located in the tmp directory, blank otherwise
In this way, you will do the lookup on disk and run 'patch' once, not twice.
Nice optimization that you have found here!

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]