Re: [Gnumed-devel] re: comm_channel

[Karsten Hilbert]

> >Unfortunately, Syan, if you create views for your own client
> >(which of itself is fine), you will be primarily responsible for
> >keeping them up-to-date with the rest of the schema, or, at least, 
> >keeping a close eye on schema changes.
> >
> not sure if you were trying to be nice by changing a view you don't use 
>  or not.
Don't worry, Syan, it's not like you are going to be left out
in the cold. Had I noticed the break I'd have fixed it. Now I
am open to suggestions.

> why not keep the original working view (that you don't use),  just 
> remove the join to comm_channel and rename identity2_comm_channel ? ( so 
> your batch setup will run?)
I am not sure I follow completely ?

> BTW , briefly looking at the changes  (at work),
> you made gmCurrentPatient accept a patient object instead of
> the patient id in its constructor ( which is really just a setter 
> method) , and moved the responsibility for retrieving the patient out of 
> gmCurrentPatient.
Yes, as discussed. One note: I re-added the functionality to
be initialized from a identity.id primary key into cPerson. I
also re-added that possibility into gmCurrentPatient. But
conceptually Ian's approach is better.

> Good idea, so it means gmCurrentPatient can potentially switch patients and
> not care whether they are in memory or retrieved. This means you can now 
> have multiple patient objects lying around in memory, and you don't have to 
> retrieve them everytime.
That is what I was referring to when I said earlier that you
can do that when you start dealing with cPerson instances
directly.

> Not sure about naming cIdentity inheriting from cOrg, but the logic is 
> ok :  the yanks ( damn their patents)
> have used Party as the superclass of person and orgs, and put the shared 
> functionaliy in there (addressability, contactibility)
Actually, I like that (cParty, not the patent business). Shall
we rename cOrg to cParty, inherit cIdentity and the *real*
cOrg from that ?

Karsten
-- 
GPG key ID E4071346 @ wwwkeys.pgp.net
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346