gnutls-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Minor fixes for gnutls 2.9.4


From: Fabian Keil
Subject: Minor fixes for gnutls 2.9.4
Date: Sat, 29 Aug 2009 13:19:43 +0200

The attached patches fix a few minor issues in
gnutls-20090829.tar.bz2, most of them pointed out by clang.

The first three ones fix sanity checks in print_* functions,
then there's a patch to improve the code clarity in crypt.c,
one that marks what looks like a bug in _gnutls_srp_pwd_read_entry()
and finally a couple of patches for write-only variables and dead
stores which may or may not be intentional.

Patch 0005 removes an apparently unnecessary (and insufficient)
NULL pointer check, and while double checking the diff I also
noticed the following code:

address@hidden ~/git/gnutls/gnutls-2.9.4 $cat -n lib/opencdk/misc.c | grep 
12[34]
   123    for (node = root->next; node; node = node->next)
   124      return node;

and wonder if an if block wouldn't be more suitable here.

Fabian

Attachment: 0001-In-print_crl-initialize-aki_idx-and-crl_nr-once-befo.patch
Description: Text Data

Attachment: 0002-In-print_crq-initialize-challenge-and-extensions-onc.patch
Description: Text Data

Attachment: 0003-In-print_extensions-initialize-_idx-variables-once-b.patch
Description: Text Data

Attachment: 0004-In-print_extensions-declare-the-_idx-variables-as-in.patch
Description: Text Data

Attachment: 0005-In-cdk_strlist_next-root-is-expected-to-be-non-NULL-.patch
Description: Text Data

Attachment: 0006-In-main-rename-salt-to-salt_size-and-don-t-bother-re.patch
Description: Text Data

Attachment: 0007-Mark-what-looks-like-a-bug-in-in-_gnutls_srp_pwd_rea.patch
Description: Text Data

Attachment: 0008-Remove-duplicates.-Two-exact-ones-and-a-pretty-close.patch
Description: Text Data

Attachment: 0009-Remove-write-only-variable-tmp_size-in-_pkcs12_decod.patch
Description: Text Data

Attachment: 0010-Remove-write-only-variable-sep_ar_idx-in-split_multi.patch
Description: Text Data

Attachment: 0011-Remove-write-only-variable-info-in-gen_rsa_export_se.patch
Description: Text Data

Attachment: 0012-Remove-write-only-variable-info-in-_gnutls_proc_cert.patch
Description: Text Data

Attachment: 0013-Remove-dead-store-in-pkcs12_info.patch
Description: Text Data

Attachment: 0014-Remove-dead-store-in-pwd_put_values.patch
Description: Text Data

Attachment: 0015-Remove-dead-store-in-gnutls_x509_crt_list_import.patch
Description: Text Data

Attachment: 0016-Remove-dead-store-in-_gnutls_io_write_buffered.patch
Description: Text Data

Attachment: 0017-Remove-dead-store-in-listen_socket.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]