Re: [gpsd-dev] [PATCH] Fixes install breakage from commit 79800e8.

[Fred Wright]

On Mon, 7 Mar 2016, Jon Schlueter wrote:

> Good catch Fred,
>
> Thanks!!!
>
> merged

Well, when I saw Gary's email, I was afraid that it was something *I'd*
broken, since I've made most of the recent changes to SConstruct and
usually haven't been testing the 'install' target (since I've generally
not been messing with the install section).  But it turns out it was just
more trouble related to cleaning up after the libgpsd removal, a.k.a. "the
gift that keeps on giving". :-)

Thanks for also picking up my other unmeged changes, including a couple
that I'd pushed to my GitHub but hadn't yet emailed.

Speaking of GitHub, in my earlier comments regarding making better use of
GitHub, one issue I forgot to mention was how to include signoffs when
merging changes directly in git.  In spite of some rather tedious
suggestions posted online for how to do this, it's actually quite simple -
just use "git cherry-pick -s".  In spite of the name, one can use
"cherry-pick" for an entire branch, updating the commit messages in the
process.  In older versions of git, one would also need to use -r to
suppress adding a cherry-pick message, but that's now the default.

BTW, I did break a couple of things recently, though not teribly
seriously.  One is that the rework of cleaning broke cleaning the Qt
objects (since the creation of the builders was disabled when cleaning).
The other is that the hack to avoid crashing scons with the -rpath option
broke Qt5 (but not Qt4) linking on OSX.  The fixes are in my GitHub
build-fixes branch, or I can post the patches here if you prefer.  Diffs
viewable here:

        https://github.com/fhgwright/gpsd/compare/master...build-fixes

Fred Wright