Re: [gpsd-users] parsing NMEA PASHR record

[Gary E. Miller]

Yo Roger!

On Wed, 20 Dec 2017 07:18:06 +0000
Roger Oberholtzer <address@hidden> wrote:

> > Yo Roger!  
> 
> > Overall this looks good.  The indentation is not right, probably
> > email related.  Also, something like this also needs a test case.
> > Do you have some sample NMEA output that has PASHR in it?  Send it
> > with the updated patch, and run it through gpsfake to see if you
> > get the output you expect.  
> 
> The indenting is an e-mail artifact. In the code it is just like all
> the other code.

Yes, So resend ass an attachment so I get a clean copy.

> We tried this in a real measurement and found that the report cycle
> changed. Whereas before the change we had lat/long with some expected
> frequency in the shared memory, after this patch we had primarily
> NaN. That is why we suspected that this patch was messing with the
> report cycle. 

Ouch.

> > If you do that, and I don't get sick again, I'll add it to git
> > head.  
> 
> We will do a bit more testing. The holidays may delay things.

I hear that.  I'm taking Thursday afternoon off to get a nice fresh
Christmas Tree!  I live in Oregon, we grow the best!

> But
> when we are ready we will happily pass it along.

I'm all about testing.  Which is why I'm also asking for sample
input files so regression tests get added at the same time as the
code.

Have you run the existing regression tests with the patch?




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgpUAlNm4gYJh.pgp
Description: OpenPGP digital signature