[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Grep-devel] [platform-testers] new snapshot available: grep-2.25.10
From: |
Jim Meyering |
Subject: |
Re: [Grep-devel] [platform-testers] new snapshot available: grep-2.25.107-f275 |
Date: |
Sat, 1 Oct 2016 20:01:07 -0700 |
On Sat, Oct 1, 2016 at 5:03 PM, Paul Eggert <address@hidden> wrote:
> I can reproduce the problem on AIX. It's due to a recent thinko in the
> progname configuration. m4/getprogname.m4 says "AC_CHECK_DECLS([__progname],
> [], [], [char *__progname;])" but this test always "succeeds" since the test
> provides the declaration that it is "testing" for. I'm not sure what that
> test is doing there (it's trying to work around some OpenBSD brain damage
> that I don't understand), but I expect this problem will hit platforms other
> than AIX so we really should fix it.
>
> If the intent is that we should test whether the library has an undeclared
> __progname variable, then I suppose we should use an AC_LINK_IFELSE for it
> instead of using AC_CHECK_DECLS.
Hi Assaf.
Thank you for the testing!
I'm glad you caught those.
Thank you, Paul, for fixing the grep-dir test to work even with
Solaris' buggy 'cat' program.
You're right. I should have used AC_LINK_IFELSE.
Fixed with the attached (pushing momentarily, then making a new snapshot):
getprogname-fix.diff
Description: Text document