[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Grep-devel] handling of non-BMP characters
From: |
Jim Meyering |
Subject: |
Re: [Grep-devel] handling of non-BMP characters |
Date: |
Sun, 16 Dec 2018 14:06:29 -0800 |
On Sun, Dec 16, 2018 at 2:00 PM Jim Meyering <address@hidden> wrote:
>
> On Sun, Dec 16, 2018 at 12:57 PM Bruno Haible <address@hidden> wrote:
> ...
> > The test was running also on glibc, *BSD, and other systems.
> >
> > In fact, it was the *only* test that verifies that 'grep' handles
> > beyond-BMP characters correctly.
> >
> > Now you have a test gap: If, by changes in glibc, in regex, in dfa,
> > in the UTF-8 converters, or elsewhere beyond-BMP characters stop working
> > on glibc or *BSD systems, no automated test will catch that.
> >
> > Therefore I would suggest to
> >
> > - revive the test,
> >
> > - rename it from 'surrogate-pair' to 'beyond-bmp' (to match what
> > it does, from a user perspective),
> >
> > - change line 2 from
> > # Trigger a segfault-inducing bug with -i in grep-2.14 on Cygwin.
> > to
> > # Check the handling of characters outside the Unicode BMP.
> >
> > - Add a comment
> > # Known failures: This test currently fails on Cygwin and AIX.
>
> You're right. I'll restore the test and adjust as you suggest after the
> release.
No need to wait until after the release. I've just pushed it with this:
https://git.savannah.gnu.org/cgit/grep.git/commit/?id=41d17c3f0ef3043c66f40349358fe9e88ca48582
- Re: [Grep-devel] [platform-testers] new snapshot available: grep-3.1.46-504af, (continued)
- Re: [Grep-devel] grep testing on AIX, Bruno Haible, 2018/12/16
- Re: [Grep-devel] [platform-testers] new snapshot available: grep-3.1.46-504af, Paul Eggert, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Bruno Haible, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Jim Meyering, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Bruno Haible, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Jim Meyering, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Bruno Haible, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Jim Meyering, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters,
Jim Meyering <=
- Re: [Grep-devel] handling of non-BMP characters, Corinna Vinschen, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Jim Meyering, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Corinna Vinschen, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Corinna Vinschen, 2018/12/16
- Re: [Grep-devel] handling of non-BMP characters, Bruno Haible, 2018/12/19
- Re: [Grep-devel] handling of non-BMP characters, Corinna Vinschen, 2018/12/19
- Re: [Grep-devel] handling of non-BMP characters, Corinna Vinschen, 2018/12/19
- Re: [Grep-devel] handling of non-BMP characters, Jim Meyering, 2018/12/19
- Re: [Grep-devel] handling of non-BMP characters, Paul Eggert, 2018/12/19
- Re: [Grep-devel] handling of non-BMP characters, arnold, 2018/12/20