[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug#461442: detection of other OSes in update-grub
From: |
Fabian Greffrath |
Subject: |
Re: Bug#461442: detection of other OSes in update-grub |
Date: |
Mon, 04 Feb 2008 15:47:26 +0100 |
User-agent: |
Thunderbird 2.0.0.9 (Windows/20071031) |
Robert Millan schrieb:
Why is that a problem?
Because foobar is not a block device, but grub-probe claims that it will
print a device if '--target=device' is given.
I think this function could be called from the other part of this file which
performs similar checks (if this functionality is to be kept, that is).
Yes, I am fine with this.
I know that the call to probe() is not supposed to be reentrant, but I'd
prefer not to break reentrancy if it can be easily avoided; it is possible
that probe() needs to recurse onto itself in the future (because of RAID/LVM).
OK, but should I keep it uninitialized?
Please remember to fix that in later versions of the patch ;-)
Sure, my copyright assignment paper is on it's way...
Is it possible to share code with 10_linux.in here?
Only if os-prober is installed. But then, os-prober does not check for
kernels on / and /target.
Maybe this can be simplified with "echo something | read a b c d" feature?
For cosmetic reasons, yes. ;)
Cheers,
Fabian
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49 (0)234 / 32-26334
Fax: +49 (0)234 / 32-14227
E-Mail: address@hidden