[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug#461442: detection of other OSes in update-grub
From: |
Robert Millan |
Subject: |
Re: Bug#461442: detection of other OSes in update-grub |
Date: |
Mon, 4 Feb 2008 16:04:00 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Mon, Feb 04, 2008 at 03:47:26PM +0100, Fabian Greffrath wrote:
> Robert Millan schrieb:
> >Why is that a problem?
> >
>
> Because foobar is not a block device, but grub-probe claims that it will
> print a device if '--target=device' is given.
Uhm I'm not sure if that's a good thing or may be overkill. What does everyone
else think about this?
> >I know that the call to probe() is not supposed to be reentrant, but I'd
> >prefer not to break reentrancy if it can be easily avoided; it is possible
> >that probe() needs to recurse onto itself in the future (because of
> >RAID/LVM).
> >
>
> OK, but should I keep it uninitialized?
Depends on what you want to do ;-)
> >Is it possible to share code with 10_linux.in here?
> >
>
> Only if os-prober is installed. But then, os-prober does not check for
> kernels on / and /target.
What I mean is that 10_linux.in already has code that probes for stuff like
Linux images and initrd files, and it might be a good idea to use the same
logic.
Or does os-prober provide any additional feature/knowledge about this?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)