Re: [PATCH] prefix redefinition fix (Re: hdparm documentation)

[Robert Millan]

On Mon, Nov 09, 2009 at 04:00:17PM +0100, Robert Millan wrote:
> === modified file 'normal/autofs.c'
> --- normal/autofs.c   2009-11-09 14:45:28 +0000
> +++ normal/autofs.c   2009-11-09 14:55:27 +0000
> @@ -51,12 +51,6 @@
>  read_fs_list (void)
>  {
>    const char *prefix;
> -  static int first_time = 1;
> -
> -  /* Make sure that this function does not get executed twice.  */
> -  if (! first_time)
> -    return;
> -  first_time = 0;
>  
>    prefix = grub_env_get ("prefix");
>    if (prefix)
> @@ -72,6 +66,15 @@
>         file = grub_file_open (filename);

Vladimir, I don't think grub_file_open() can cause read_fs_list() to be invoked
recursively.  Note that read_fs_list() is not called when probing for
filesystems, only during initialization (before my patch, only once, and after
my patch, additionally each time ${prefix} is written to).

Do you still see a problem with this patch?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."